feat/system-team-cd #48
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/system-team-cd"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
also i would restructure the controller deployment so that we structure it by controller, then target, then purpose
cd/base/controllers/<controller>/<workspace or cluster>/<purpose>examples:
cd/base/controllers/cluster/kcp-root-controllers-cluster/provision-workspace
cd/base/controllers/cluster/kcp-root-controllers/init-workspace
cd/base/controllers/cluster/parent/deploy-app
I have no strong opinion on naming convention for
<workspace or cluster>@ -0,0 +7,4 @@files:- values.yamlgeneratorOptions:disableNameSuffixHash: truei would also enable the suffix generation for config maps, so that we can ensure that the job is being recreated and rerun on redeployment. And also, that the kubelet mounted the most up to date configmap.
@ -0,0 +25,4 @@clusters:- name: kcp-clustercluster:server: https://kcp-deploy-front-proxy.kcp-deploy.svc.cluster.local:8443/clusters/root:controllers:clusterthis should be deployed to
root:controllersWhat do you mean?
Each controller belongs to the it's own kcp ws.
In this case it's root:controllers:cluster.
aahhh i see you create the kubeconfig used by the other jobs here. Might make sense to create a kubeconfig for each job, when the job is being applied to the parent cluster.
i mean that in these manifests there is a ExternalSecret and Certififcate that in this case points to
https://kcp-deploy-front-proxy.kcp-deploy.svc.cluster.local:8443/clusters/root:controllersso that everything that is required for that apply is created during the kustomize apply. Which has the advantage, that i dont need to look for any other resource in the repo if i want to understand what is being deployed in this subfolder.@ -0,0 +7,4 @@configMapGenerator:- name: kcp-cluster-manifestsfiles:- ws.yamli'd like to change the folder structure in a way to in a first glance what is being deployed on KCP and what on base cluster
:o that image was from the other folder, i would do it the same
@ -0,0 +63,4 @@volumes:- name: kubeconfigsecret:secretName: kcp-cluster-kubeconfigthis kubeconfig is not well-defined (at least not defined in this folder, so it is ambiguous where its being deployed)
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.