DevFW-CICD/garm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Make runner names lowercase

Browse source 
It seems that on some systems like k8s, rfc 1123 is a hard requirement
and validation fails if hostnames have any uppercase letters, leading to
nodes not being able to join.

This change makes all runner names lowercase, hopefully fixing this.

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This commit is contained in:
Gabriel Adrian Samfira 2026-02-14 19:58:40 +02:00 • committed by Gabriel
parent 3acbee4582
commit c8844e543c
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
runner/pool/pool.go
View file

@ -874,7 +874,7 @@ func (r *basePoolManager) AddRunner(ctx context.Context, poolID string, aditiona
return fmt.Errorf("unknown provider %s for pool %s", pool.ProviderName, pool.ID)
}
name := fmt.Sprintf("%s-%s", pool.GetRunnerPrefix(), util.NewID())
name := strings.ToLower(fmt.Sprintf("%s-%s", pool.GetRunnerPrefix(), util.NewID()))
labels := r.getLabelsForInstance(pool)
jitConfig := make(map[string]string)

3
workers/scaleset/scaleset.go
View file

@ -18,6 +18,7 @@ import (
"errors"
"fmt"
"log/slog"
"strings"
"sync"
"time"
@ -814,7 +815,7 @@ func (w *Worker) handleScaleUp() {
return
}
for i := w.runnerCount(); i < w.targetRunners(); i++ {
newRunnerName := fmt.Sprintf("%s-%s", w.scaleSet.GetRunnerPrefix(), util.NewID())
newRunnerName := strings.ToLower(fmt.Sprintf("%s-%s", w.scaleSet.GetRunnerPrefix(), util.NewID()))
jitConfig, err := scaleSetCli.GenerateJitRunnerConfig(w.ctx, newRunnerName, w.scaleSet.ScaleSetID)
if err != nil {
slog.ErrorContext(w.ctx, "error generating jit config", "error", err)