From c8844e543c5b5968775fcb990c5bd23c8f90bae6 Mon Sep 17 00:00:00 2001 From: Gabriel Adrian Samfira Date: Sat, 14 Feb 2026 19:58:40 +0200 Subject: [PATCH] Make runner names lowercase It seems that on some systems like k8s, rfc 1123 is a hard requirement and validation fails if hostnames have any uppercase letters, leading to nodes not being able to join. This change makes all runner names lowercase, hopefully fixing this. Signed-off-by: Gabriel Adrian Samfira --- runner/pool/pool.go | 2 +- workers/scaleset/scaleset.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/runner/pool/pool.go b/runner/pool/pool.go index ce0f052e..11b3b8a2 100644 --- a/runner/pool/pool.go +++ b/runner/pool/pool.go @@ -874,7 +874,7 @@ func (r *basePoolManager) AddRunner(ctx context.Context, poolID string, aditiona return fmt.Errorf("unknown provider %s for pool %s", pool.ProviderName, pool.ID) } - name := fmt.Sprintf("%s-%s", pool.GetRunnerPrefix(), util.NewID()) + name := strings.ToLower(fmt.Sprintf("%s-%s", pool.GetRunnerPrefix(), util.NewID())) labels := r.getLabelsForInstance(pool) jitConfig := make(map[string]string) diff --git a/workers/scaleset/scaleset.go b/workers/scaleset/scaleset.go index 26088e61..683470b1 100644 --- a/workers/scaleset/scaleset.go +++ b/workers/scaleset/scaleset.go @@ -18,6 +18,7 @@ import ( "errors" "fmt" "log/slog" + "strings" "sync" "time" @@ -814,7 +815,7 @@ func (w *Worker) handleScaleUp() { return } for i := w.runnerCount(); i < w.targetRunners(); i++ { - newRunnerName := fmt.Sprintf("%s-%s", w.scaleSet.GetRunnerPrefix(), util.NewID()) + newRunnerName := strings.ToLower(fmt.Sprintf("%s-%s", w.scaleSet.GetRunnerPrefix(), util.NewID())) jitConfig, err := scaleSetCli.GenerateJitRunnerConfig(w.ctx, newRunnerName, w.scaleSet.ScaleSetID) if err != nil { slog.ErrorContext(w.ctx, "error generating jit config", "error", err)