DevFW-CICD/runner
16
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Fix potential panic caused by nil Step (#48)

Browse source 
```yml
jobs:
  job1:
    steps:
      - run: echo HelloWorld
      - # empty step
```

If a job contains an empty step, `Job.Steps` will have a nil element and will cause panic when calling `Step.String()`.

See [the code of gitea](948a9ee5e8/models/actions/task.go (L300-L301))

Reviewed-on: https://gitea.com/gitea/act/pulls/48
Co-authored-by: Zettat123 <zettat123@gmail.com>
Co-committed-by: Zettat123 <zettat123@gmail.com>
This commit is contained in:
Zettat123 2023-04-21 14:45:38 +08:00 • committed by Jason Song
parent 42f2894acc
commit f1c4dec079
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
act/jobparser/model.go
View file

@ -143,6 +143,9 @@ type Step struct {
// String gets the name of step
func (s *Step) String() string {
if s == nil {
return ""
}
return (&model.Step{
ID: s.ID,
Name: s.Name,