be4f303b82
This change removes a check that denies the creation of a pool if the new pool has the same image and flavor set on the same provider. The reasoning for that check was that if you need to create another pool with identical settings to an existing one, you might as well scale up the min-idle-runners on the old one. This was done when runner groups were not yet added. This in turn has forced users to alias images with new names in their provider, leading to terrible UX. In the end, being too opinionated in this case has caused more harm than good. Fixes #245 Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
792 lines
30 KiB
Go
792 lines
30 KiB
Go
// Copyright 2022 Cloudbase Solutions SRL
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
// not use this file except in compliance with the License. You may obtain
|
|
// a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
// License for the specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package sql
|
|
|
|
import (
|
|
"context"
|
|
"flag"
|
|
"fmt"
|
|
"regexp"
|
|
"sort"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
"gopkg.in/DATA-DOG/go-sqlmock.v1"
|
|
"gorm.io/driver/mysql"
|
|
"gorm.io/gorm"
|
|
"gorm.io/gorm/logger"
|
|
|
|
"github.com/cloudbase/garm/auth"
|
|
dbCommon "github.com/cloudbase/garm/database/common"
|
|
garmTesting "github.com/cloudbase/garm/internal/testing"
|
|
"github.com/cloudbase/garm/params"
|
|
)
|
|
|
|
type OrgTestFixtures struct {
|
|
Orgs []params.Organization
|
|
CreateOrgParams params.CreateOrgParams
|
|
CreatePoolParams params.CreatePoolParams
|
|
CreateInstanceParams params.CreateInstanceParams
|
|
UpdateRepoParams params.UpdateEntityParams
|
|
UpdatePoolParams params.UpdatePoolParams
|
|
SQLMock sqlmock.Sqlmock
|
|
}
|
|
|
|
type OrgTestSuite struct {
|
|
suite.Suite
|
|
Store dbCommon.Store
|
|
StoreSQLMocked *sqlDatabase
|
|
Fixtures *OrgTestFixtures
|
|
|
|
adminCtx context.Context
|
|
adminUserID string
|
|
|
|
testCreds params.GithubCredentials
|
|
secondaryTestCreds params.GithubCredentials
|
|
githubEndpoint params.GithubEndpoint
|
|
}
|
|
|
|
func (s *OrgTestSuite) equalInstancesByName(expected, actual []params.Instance) {
|
|
s.Require().Equal(len(expected), len(actual))
|
|
|
|
sort.Slice(expected, func(i, j int) bool { return expected[i].Name > expected[j].Name })
|
|
sort.Slice(actual, func(i, j int) bool { return actual[i].Name > actual[j].Name })
|
|
|
|
for i := 0; i < len(expected); i++ {
|
|
s.Require().Equal(expected[i].Name, actual[i].Name)
|
|
}
|
|
}
|
|
|
|
func (s *OrgTestSuite) assertSQLMockExpectations() {
|
|
err := s.Fixtures.SQLMock.ExpectationsWereMet()
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("failed to meet sqlmock expectations, got error: %v", err))
|
|
}
|
|
}
|
|
|
|
func (s *OrgTestSuite) SetupTest() {
|
|
// create testing sqlite database
|
|
dbConfig := garmTesting.GetTestSqliteDBConfig(s.T())
|
|
db, err := NewSQLDatabase(context.Background(), dbConfig)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("failed to create db connection: %s", err))
|
|
}
|
|
s.Store = db
|
|
|
|
adminCtx := garmTesting.ImpersonateAdminContext(context.Background(), db, s.T())
|
|
s.adminCtx = adminCtx
|
|
s.adminUserID = auth.UserID(adminCtx)
|
|
s.Require().NotEmpty(s.adminUserID)
|
|
|
|
s.githubEndpoint = garmTesting.CreateDefaultGithubEndpoint(adminCtx, db, s.T())
|
|
s.testCreds = garmTesting.CreateTestGithubCredentials(adminCtx, "new-creds", db, s.T(), s.githubEndpoint)
|
|
s.secondaryTestCreds = garmTesting.CreateTestGithubCredentials(adminCtx, "secondary-creds", db, s.T(), s.githubEndpoint)
|
|
|
|
// create some organization objects in the database, for testing purposes
|
|
orgs := []params.Organization{}
|
|
for i := 1; i <= 3; i++ {
|
|
org, err := db.CreateOrganization(
|
|
s.adminCtx,
|
|
fmt.Sprintf("test-org-%d", i),
|
|
s.testCreds.Name,
|
|
fmt.Sprintf("test-webhook-secret-%d", i),
|
|
params.PoolBalancerTypeRoundRobin,
|
|
)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("failed to create database object (test-org-%d): %q", i, err))
|
|
}
|
|
|
|
orgs = append(orgs, org)
|
|
}
|
|
|
|
// create store with mocked sql connection
|
|
sqlDB, sqlMock, err := sqlmock.New()
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("failed to run 'sqlmock.New()', got error: %v", err))
|
|
}
|
|
s.T().Cleanup(func() { sqlDB.Close() })
|
|
mysqlConfig := mysql.Config{
|
|
Conn: sqlDB,
|
|
SkipInitializeWithVersion: true,
|
|
}
|
|
gormConfig := &gorm.Config{}
|
|
if flag.Lookup("test.v").Value.String() == falseString {
|
|
gormConfig.Logger = logger.Default.LogMode(logger.Silent)
|
|
}
|
|
gormConn, err := gorm.Open(mysql.New(mysqlConfig), gormConfig)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("fail to open gorm connection: %v", err))
|
|
}
|
|
s.StoreSQLMocked = &sqlDatabase{
|
|
conn: gormConn,
|
|
cfg: dbConfig,
|
|
}
|
|
|
|
// setup test fixtures
|
|
var maxRunners uint = 30
|
|
var minIdleRunners uint = 10
|
|
fixtures := &OrgTestFixtures{
|
|
Orgs: orgs,
|
|
CreateOrgParams: params.CreateOrgParams{
|
|
Name: s.testCreds.Name,
|
|
CredentialsName: s.testCreds.Name,
|
|
WebhookSecret: "new-webhook-secret",
|
|
},
|
|
CreatePoolParams: params.CreatePoolParams{
|
|
ProviderName: "test-provider",
|
|
MaxRunners: 3,
|
|
MinIdleRunners: 1,
|
|
Enabled: true,
|
|
Image: "test-image",
|
|
Flavor: "test-flavor",
|
|
OSType: "linux",
|
|
OSArch: "amd64",
|
|
Tags: []string{"self-hosted", "arm64", "linux"},
|
|
},
|
|
CreateInstanceParams: params.CreateInstanceParams{
|
|
Name: "test-instance-name",
|
|
OSType: "linux",
|
|
},
|
|
UpdateRepoParams: params.UpdateEntityParams{
|
|
CredentialsName: s.secondaryTestCreds.Name,
|
|
WebhookSecret: "test-update-repo-webhook-secret",
|
|
},
|
|
UpdatePoolParams: params.UpdatePoolParams{
|
|
MaxRunners: &maxRunners,
|
|
MinIdleRunners: &minIdleRunners,
|
|
Image: "test-update-image",
|
|
Flavor: "test-update-flavor",
|
|
},
|
|
SQLMock: sqlMock,
|
|
}
|
|
s.Fixtures = fixtures
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganization() {
|
|
// call tested function
|
|
org, err := s.Store.CreateOrganization(
|
|
s.adminCtx,
|
|
s.Fixtures.CreateOrgParams.Name,
|
|
s.Fixtures.CreateOrgParams.CredentialsName,
|
|
s.Fixtures.CreateOrgParams.WebhookSecret,
|
|
params.PoolBalancerTypeRoundRobin)
|
|
|
|
// assertions
|
|
s.Require().Nil(err)
|
|
storeOrg, err := s.Store.GetOrganizationByID(s.adminCtx, org.ID)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("failed to get organization by id: %v", err))
|
|
}
|
|
s.Require().Equal(storeOrg.Name, org.Name)
|
|
s.Require().Equal(storeOrg.Credentials.Name, org.Credentials.Name)
|
|
s.Require().Equal(storeOrg.WebhookSecret, org.WebhookSecret)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationInvalidDBPassphrase() {
|
|
cfg := garmTesting.GetTestSqliteDBConfig(s.T())
|
|
conn, err := newDBConn(cfg)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("failed to create db connection: %s", err))
|
|
}
|
|
// make sure we use a 'sqlDatabase' struct with a wrong 'cfg.Passphrase'
|
|
cfg.Passphrase = wrongPassphrase // it must have a size different than 32
|
|
sqlDB := &sqlDatabase{
|
|
conn: conn,
|
|
cfg: cfg,
|
|
}
|
|
|
|
_, err = sqlDB.CreateOrganization(
|
|
s.adminCtx,
|
|
s.Fixtures.CreateOrgParams.Name,
|
|
s.Fixtures.CreateOrgParams.CredentialsName,
|
|
s.Fixtures.CreateOrgParams.WebhookSecret,
|
|
params.PoolBalancerTypeRoundRobin)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("encoding secret: invalid passphrase length (expected length 32 characters)", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationDBCreateErr() {
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_credentials` WHERE user_id = ? AND name = ? AND `github_credentials`.`deleted_at` IS NULL ORDER BY `github_credentials`.`id` LIMIT ?")).
|
|
WithArgs(s.adminUserID, s.Fixtures.Orgs[0].CredentialsName, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "endpoint_name"}).
|
|
AddRow(s.testCreds.ID, s.githubEndpoint.Name))
|
|
s.Fixtures.SQLMock.ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_endpoints` WHERE `github_endpoints`.`name` = ? AND `github_endpoints`.`deleted_at` IS NULL")).
|
|
WithArgs(s.testCreds.Endpoint.Name).
|
|
WillReturnRows(sqlmock.NewRows([]string{"name"}).
|
|
AddRow(s.githubEndpoint.Name))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `organizations`")).
|
|
WillReturnError(fmt.Errorf("creating org mock error"))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
_, err := s.StoreSQLMocked.CreateOrganization(
|
|
s.adminCtx,
|
|
s.Fixtures.CreateOrgParams.Name,
|
|
s.Fixtures.CreateOrgParams.CredentialsName,
|
|
s.Fixtures.CreateOrgParams.WebhookSecret,
|
|
params.PoolBalancerTypeRoundRobin)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("creating org: creating org: creating org mock error", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganization() {
|
|
org, err := s.Store.GetOrganization(s.adminCtx, s.Fixtures.Orgs[0].Name)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(s.Fixtures.Orgs[0].Name, org.Name)
|
|
s.Require().Equal(s.Fixtures.Orgs[0].ID, org.ID)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationCaseInsensitive() {
|
|
org, err := s.Store.GetOrganization(s.adminCtx, "TeSt-oRg-1")
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Equal("test-org-1", org.Name)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationNotFound() {
|
|
_, err := s.Store.GetOrganization(s.adminCtx, "dummy-name")
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching org: not found", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationDBDecryptingErr() {
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE name = ? COLLATE NOCASE AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].Name, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"name"}).AddRow(s.Fixtures.Orgs[0].Name))
|
|
|
|
_, err := s.StoreSQLMocked.GetOrganization(s.adminCtx, s.Fixtures.Orgs[0].Name)
|
|
|
|
s.assertSQLMockExpectations()
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching org: missing secret", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestListOrganizations() {
|
|
orgs, err := s.Store.ListOrganizations(s.adminCtx)
|
|
|
|
s.Require().Nil(err)
|
|
garmTesting.EqualDBEntityByName(s.T(), s.Fixtures.Orgs, orgs)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestListOrganizationsDBFetchErr() {
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE `organizations`.`deleted_at` IS NULL")).
|
|
WillReturnError(fmt.Errorf("fetching user from database mock error"))
|
|
|
|
_, err := s.StoreSQLMocked.ListOrganizations(s.adminCtx)
|
|
|
|
s.assertSQLMockExpectations()
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching org from database: fetching user from database mock error", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestDeleteOrganization() {
|
|
err := s.Store.DeleteOrganization(s.adminCtx, s.Fixtures.Orgs[0].ID)
|
|
|
|
s.Require().Nil(err)
|
|
_, err = s.Store.GetOrganizationByID(s.adminCtx, s.Fixtures.Orgs[0].ID)
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching org: not found", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestDeleteOrganizationInvalidOrgID() {
|
|
err := s.Store.DeleteOrganization(s.adminCtx, "dummy-org-id")
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching org: parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestDeleteOrganizationDBDeleteErr() {
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(s.Fixtures.Orgs[0].ID))
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("DELETE FROM `organizations`")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID).
|
|
WillReturnError(fmt.Errorf("mocked delete org error"))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
err := s.StoreSQLMocked.DeleteOrganization(s.adminCtx, s.Fixtures.Orgs[0].ID)
|
|
|
|
s.assertSQLMockExpectations()
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("deleting org: mocked delete org error", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestUpdateOrganization() {
|
|
org, err := s.Store.UpdateOrganization(s.adminCtx, s.Fixtures.Orgs[0].ID, s.Fixtures.UpdateRepoParams)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(s.Fixtures.UpdateRepoParams.CredentialsName, org.Credentials.Name)
|
|
s.Require().Equal(s.Fixtures.UpdateRepoParams.WebhookSecret, org.WebhookSecret)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestUpdateOrganizationInvalidOrgID() {
|
|
_, err := s.Store.UpdateOrganization(s.adminCtx, "dummy-org-id", s.Fixtures.UpdateRepoParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("saving org: fetching org: parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestUpdateOrganizationDBEncryptErr() {
|
|
s.StoreSQLMocked.cfg.Passphrase = wrongPassphrase
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "endpoint_name"}).
|
|
AddRow(s.Fixtures.Orgs[0].ID, s.Fixtures.Orgs[0].Endpoint.Name))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_credentials` WHERE user_id = ? AND name = ? AND `github_credentials`.`deleted_at` IS NULL ORDER BY `github_credentials`.`id` LIMIT ?")).
|
|
WithArgs(s.adminUserID, s.secondaryTestCreds.Name, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "endpoint_name"}).
|
|
AddRow(s.secondaryTestCreds.ID, s.secondaryTestCreds.Endpoint.Name))
|
|
s.Fixtures.SQLMock.ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_endpoints` WHERE `github_endpoints`.`name` = ? AND `github_endpoints`.`deleted_at` IS NULL")).
|
|
WithArgs(s.testCreds.Endpoint.Name).
|
|
WillReturnRows(sqlmock.NewRows([]string{"name"}).
|
|
AddRow(s.secondaryTestCreds.Endpoint.Name))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
_, err := s.StoreSQLMocked.UpdateOrganization(s.adminCtx, s.Fixtures.Orgs[0].ID, s.Fixtures.UpdateRepoParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("saving org: saving org: failed to encrypt string: invalid passphrase length (expected length 32 characters)", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestUpdateOrganizationDBSaveErr() {
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "endpoint_name"}).
|
|
AddRow(s.Fixtures.Orgs[0].ID, s.Fixtures.Orgs[0].Endpoint.Name))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_credentials` WHERE user_id = ? AND name = ? AND `github_credentials`.`deleted_at` IS NULL ORDER BY `github_credentials`.`id` LIMIT ?")).
|
|
WithArgs(s.adminUserID, s.secondaryTestCreds.Name, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "endpoint_name"}).
|
|
AddRow(s.secondaryTestCreds.ID, s.secondaryTestCreds.Endpoint.Name))
|
|
s.Fixtures.SQLMock.ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_endpoints` WHERE `github_endpoints`.`name` = ? AND `github_endpoints`.`deleted_at` IS NULL")).
|
|
WithArgs(s.testCreds.Endpoint.Name).
|
|
WillReturnRows(sqlmock.NewRows([]string{"name"}).
|
|
AddRow(s.secondaryTestCreds.Endpoint.Name))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(("UPDATE `organizations` SET")).
|
|
WillReturnError(fmt.Errorf("saving org mock error"))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
_, err := s.StoreSQLMocked.UpdateOrganization(s.adminCtx, s.Fixtures.Orgs[0].ID, s.Fixtures.UpdateRepoParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("saving org: saving org: saving org mock error", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestUpdateOrganizationDBDecryptingErr() {
|
|
s.StoreSQLMocked.cfg.Passphrase = wrongPassphrase
|
|
s.Fixtures.UpdateRepoParams.WebhookSecret = webhookSecret
|
|
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "endpoint_name"}).
|
|
AddRow(s.Fixtures.Orgs[0].ID, s.Fixtures.Orgs[0].Endpoint.Name))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_credentials` WHERE user_id = ? AND name = ? AND `github_credentials`.`deleted_at` IS NULL ORDER BY `github_credentials`.`id` LIMIT ?")).
|
|
WithArgs(s.adminUserID, s.secondaryTestCreds.Name, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id", "endpoint_name"}).
|
|
AddRow(s.secondaryTestCreds.ID, s.secondaryTestCreds.Endpoint.Name))
|
|
s.Fixtures.SQLMock.ExpectQuery(regexp.QuoteMeta("SELECT * FROM `github_endpoints` WHERE `github_endpoints`.`name` = ? AND `github_endpoints`.`deleted_at` IS NULL")).
|
|
WithArgs(s.testCreds.Endpoint.Name).
|
|
WillReturnRows(sqlmock.NewRows([]string{"name"}).
|
|
AddRow(s.secondaryTestCreds.Endpoint.Name))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
_, err := s.StoreSQLMocked.UpdateOrganization(s.adminCtx, s.Fixtures.Orgs[0].ID, s.Fixtures.UpdateRepoParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("saving org: saving org: failed to encrypt string: invalid passphrase length (expected length 32 characters)", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationByID() {
|
|
org, err := s.Store.GetOrganizationByID(s.adminCtx, s.Fixtures.Orgs[0].ID)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(s.Fixtures.Orgs[0].ID, org.ID)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationByIDInvalidOrgID() {
|
|
_, err := s.Store.GetOrganizationByID(s.adminCtx, "dummy-org-id")
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching org: parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationByIDDBDecryptingErr() {
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(s.Fixtures.Orgs[0].ID))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `pools` WHERE `pools`.`org_id` = ? AND `pools`.`deleted_at` IS NULL")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID).
|
|
WillReturnRows(sqlmock.NewRows([]string{"org_id"}).AddRow(s.Fixtures.Orgs[0].ID))
|
|
|
|
_, err := s.StoreSQLMocked.GetOrganizationByID(s.adminCtx, s.Fixtures.Orgs[0].ID)
|
|
|
|
s.assertSQLMockExpectations()
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching org: missing secret", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationPool() {
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
pool, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
|
|
s.Require().Nil(err)
|
|
|
|
org, err := s.Store.GetOrganizationByID(s.adminCtx, s.Fixtures.Orgs[0].ID)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot get org by ID: %v", err))
|
|
}
|
|
s.Require().Equal(1, len(org.Pools))
|
|
s.Require().Equal(pool.ID, org.Pools[0].ID)
|
|
s.Require().Equal(s.Fixtures.CreatePoolParams.ProviderName, org.Pools[0].ProviderName)
|
|
s.Require().Equal(s.Fixtures.CreatePoolParams.MaxRunners, org.Pools[0].MaxRunners)
|
|
s.Require().Equal(s.Fixtures.CreatePoolParams.MinIdleRunners, org.Pools[0].MinIdleRunners)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationPoolMissingTags() {
|
|
s.Fixtures.CreatePoolParams.Tags = []string{}
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
_, err = s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("no tags specified", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationPoolInvalidOrgID() {
|
|
entity := params.GithubEntity{
|
|
ID: "dummy-org-id",
|
|
EntityType: params.GithubEntityTypeOrganization,
|
|
}
|
|
_, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationPoolDBFetchTagErr() {
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(s.Fixtures.Orgs[0].ID))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `tags` WHERE name = ? AND `tags`.`deleted_at` IS NULL ORDER BY `tags`.`id` LIMIT ?")).
|
|
WillReturnError(fmt.Errorf("mocked fetching tag error"))
|
|
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
_, err = s.StoreSQLMocked.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("creating tag: fetching tag from database: mocked fetching tag error", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationPoolDBAddingPoolErr() {
|
|
s.Fixtures.CreatePoolParams.Tags = []string{"linux"}
|
|
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(s.Fixtures.Orgs[0].ID))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `tags` WHERE name = ? AND `tags`.`deleted_at` IS NULL ORDER BY `tags`.`id` LIMIT ?")).
|
|
WillReturnRows(sqlmock.NewRows([]string{"linux"}))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `tags`")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `pools`")).
|
|
WillReturnError(fmt.Errorf("mocked adding pool error"))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
_, err = s.StoreSQLMocked.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("creating pool: mocked adding pool error", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationPoolDBSaveTagErr() {
|
|
s.Fixtures.CreatePoolParams.Tags = []string{"linux"}
|
|
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(s.Fixtures.Orgs[0].ID))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `tags` WHERE name = ? AND `tags`.`deleted_at` IS NULL ORDER BY `tags`.`id` LIMIT ?")).
|
|
WillReturnRows(sqlmock.NewRows([]string{"linux"}))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `tags`")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `pools`")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("UPDATE `pools` SET")).
|
|
WillReturnError(fmt.Errorf("mocked saving tag error"))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
_, err = s.StoreSQLMocked.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("associating tags: mocked saving tag error", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestCreateOrganizationPoolDBFetchPoolErr() {
|
|
s.Fixtures.CreatePoolParams.Tags = []string{"linux"}
|
|
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `organizations` WHERE id = ? AND `organizations`.`deleted_at` IS NULL ORDER BY `organizations`.`id` LIMIT ?")).
|
|
WithArgs(s.Fixtures.Orgs[0].ID, 1).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id"}).AddRow(s.Fixtures.Orgs[0].ID))
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `tags` WHERE name = ? AND `tags`.`deleted_at` IS NULL ORDER BY `tags`.`id` LIMIT ?")).
|
|
WillReturnRows(sqlmock.NewRows([]string{"linux"}))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `tags`")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `pools`")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("UPDATE `pools` SET")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `tags`")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("INSERT INTO `pool_tags`")).
|
|
WillReturnResult(sqlmock.NewResult(1, 1))
|
|
s.Fixtures.SQLMock.ExpectCommit()
|
|
s.Fixtures.SQLMock.
|
|
ExpectQuery(regexp.QuoteMeta("SELECT * FROM `pools` WHERE id = ? AND `pools`.`deleted_at` IS NULL ORDER BY `pools`.`id` LIMIT ?")).
|
|
WillReturnRows(sqlmock.NewRows([]string{"id"}))
|
|
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
|
|
_, err = s.StoreSQLMocked.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching pool: not found", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestListOrgPools() {
|
|
orgPools := []params.Pool{}
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
for i := 1; i <= 2; i++ {
|
|
s.Fixtures.CreatePoolParams.Flavor = fmt.Sprintf("test-flavor-%v", i)
|
|
pool, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot create org pool: %v", err))
|
|
}
|
|
orgPools = append(orgPools, pool)
|
|
}
|
|
pools, err := s.Store.ListEntityPools(s.adminCtx, entity)
|
|
|
|
s.Require().Nil(err)
|
|
garmTesting.EqualDBEntityID(s.T(), orgPools, pools)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestListOrgPoolsInvalidOrgID() {
|
|
entity := params.GithubEntity{
|
|
ID: "dummy-org-id",
|
|
EntityType: params.GithubEntityTypeOrganization,
|
|
}
|
|
_, err := s.Store.ListEntityPools(s.adminCtx, entity)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching pools: parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationPool() {
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
pool, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot create org pool: %v", err))
|
|
}
|
|
|
|
orgPool, err := s.Store.GetEntityPool(s.adminCtx, entity, pool.ID)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(orgPool.ID, pool.ID)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestGetOrganizationPoolInvalidOrgID() {
|
|
entity := params.GithubEntity{
|
|
ID: "dummy-org-id",
|
|
EntityType: params.GithubEntityTypeOrganization,
|
|
}
|
|
_, err := s.Store.GetEntityPool(s.adminCtx, entity, "dummy-pool-id")
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching pool: parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestDeleteOrganizationPool() {
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
pool, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot create org pool: %v", err))
|
|
}
|
|
|
|
err = s.Store.DeleteEntityPool(s.adminCtx, entity, pool.ID)
|
|
|
|
s.Require().Nil(err)
|
|
_, err = s.Store.GetEntityPool(s.adminCtx, entity, pool.ID)
|
|
s.Require().Equal("fetching pool: finding pool: not found", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestDeleteOrganizationPoolInvalidOrgID() {
|
|
entity := params.GithubEntity{
|
|
ID: "dummy-org-id",
|
|
EntityType: params.GithubEntityTypeOrganization,
|
|
}
|
|
err := s.Store.DeleteEntityPool(s.adminCtx, entity, "dummy-pool-id")
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestDeleteOrganizationPoolDBDeleteErr() {
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
|
|
pool, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot create org pool: %v", err))
|
|
}
|
|
|
|
s.Fixtures.SQLMock.ExpectBegin()
|
|
s.Fixtures.SQLMock.
|
|
ExpectExec(regexp.QuoteMeta("DELETE FROM `pools` WHERE id = ? and org_id = ?")).
|
|
WithArgs(pool.ID, s.Fixtures.Orgs[0].ID).
|
|
WillReturnError(fmt.Errorf("mocked deleting pool error"))
|
|
s.Fixtures.SQLMock.ExpectRollback()
|
|
|
|
err = s.StoreSQLMocked.DeleteEntityPool(s.adminCtx, entity, pool.ID)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("removing pool: mocked deleting pool error", err.Error())
|
|
s.assertSQLMockExpectations()
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestListOrgInstances() {
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
pool, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot create org pool: %v", err))
|
|
}
|
|
poolInstances := []params.Instance{}
|
|
for i := 1; i <= 3; i++ {
|
|
s.Fixtures.CreateInstanceParams.Name = fmt.Sprintf("test-org-%v", i)
|
|
instance, err := s.Store.CreateInstance(s.adminCtx, pool.ID, s.Fixtures.CreateInstanceParams)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot create instance: %s", err))
|
|
}
|
|
poolInstances = append(poolInstances, instance)
|
|
}
|
|
|
|
instances, err := s.Store.ListEntityInstances(s.adminCtx, entity)
|
|
|
|
s.Require().Nil(err)
|
|
s.equalInstancesByName(poolInstances, instances)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestListOrgInstancesInvalidOrgID() {
|
|
entity := params.GithubEntity{
|
|
ID: "dummy-org-id",
|
|
EntityType: params.GithubEntityTypeOrganization,
|
|
}
|
|
_, err := s.Store.ListEntityInstances(s.adminCtx, entity)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching entity: parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestUpdateOrganizationPool() {
|
|
entity, err := s.Fixtures.Orgs[0].GetEntity()
|
|
s.Require().Nil(err)
|
|
pool, err := s.Store.CreateEntityPool(s.adminCtx, entity, s.Fixtures.CreatePoolParams)
|
|
if err != nil {
|
|
s.FailNow(fmt.Sprintf("cannot create org pool: %v", err))
|
|
}
|
|
|
|
pool, err = s.Store.UpdateEntityPool(s.adminCtx, entity, pool.ID, s.Fixtures.UpdatePoolParams)
|
|
|
|
s.Require().Nil(err)
|
|
s.Require().Equal(*s.Fixtures.UpdatePoolParams.MaxRunners, pool.MaxRunners)
|
|
s.Require().Equal(*s.Fixtures.UpdatePoolParams.MinIdleRunners, pool.MinIdleRunners)
|
|
s.Require().Equal(s.Fixtures.UpdatePoolParams.Image, pool.Image)
|
|
s.Require().Equal(s.Fixtures.UpdatePoolParams.Flavor, pool.Flavor)
|
|
}
|
|
|
|
func (s *OrgTestSuite) TestUpdateOrganizationPoolInvalidOrgID() {
|
|
entity := params.GithubEntity{
|
|
ID: "dummy-org-id",
|
|
EntityType: params.GithubEntityTypeOrganization,
|
|
}
|
|
_, err := s.Store.UpdateEntityPool(s.adminCtx, entity, "dummy-pool-id", s.Fixtures.UpdatePoolParams)
|
|
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal("fetching pool: parsing id: invalid request", err.Error())
|
|
}
|
|
|
|
func TestOrgTestSuite(t *testing.T) {
|
|
t.Parallel()
|
|
suite.Run(t, new(OrgTestSuite))
|
|
}
|