be4f303b82
This change removes a check that denies the creation of a pool if the new pool has the same image and flavor set on the same provider. The reasoning for that check was that if you need to create another pool with identical settings to an existing one, you might as well scale up the min-idle-runners on the old one. This was done when runner groups were not yet added. This in turn has forced users to alias images with new names in their provider, leading to terrible UX. In the end, being too opinionated in this case has caused more harm than good. Fixes #245 Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
413 lines
12 KiB
Go
413 lines
12 KiB
Go
// Copyright 2022 Cloudbase Solutions SRL
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
// not use this file except in compliance with the License. You may obtain
|
|
// a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
// License for the specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package sql
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/pkg/errors"
|
|
"gorm.io/datatypes"
|
|
"gorm.io/gorm"
|
|
|
|
runnerErrors "github.com/cloudbase/garm-provider-common/errors"
|
|
"github.com/cloudbase/garm/params"
|
|
)
|
|
|
|
const (
|
|
entityTypeEnterpriseName = "enterprise_id"
|
|
entityTypeOrgName = "org_id"
|
|
entityTypeRepoName = "repo_id"
|
|
)
|
|
|
|
func (s *sqlDatabase) ListAllPools(_ context.Context) ([]params.Pool, error) {
|
|
var pools []Pool
|
|
|
|
q := s.conn.Model(&Pool{}).
|
|
Preload("Tags").
|
|
Preload("Organization").
|
|
Preload("Repository").
|
|
Preload("Enterprise").
|
|
Omit("extra_specs").
|
|
Find(&pools)
|
|
if q.Error != nil {
|
|
return nil, errors.Wrap(q.Error, "fetching all pools")
|
|
}
|
|
|
|
ret := make([]params.Pool, len(pools))
|
|
var err error
|
|
for idx, val := range pools {
|
|
ret[idx], err = s.sqlToCommonPool(val)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "converting pool")
|
|
}
|
|
}
|
|
return ret, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) GetPoolByID(_ context.Context, poolID string) (params.Pool, error) {
|
|
pool, err := s.getPoolByID(s.conn, poolID, "Tags", "Instances", "Enterprise", "Organization", "Repository")
|
|
if err != nil {
|
|
return params.Pool{}, errors.Wrap(err, "fetching pool by ID")
|
|
}
|
|
return s.sqlToCommonPool(pool)
|
|
}
|
|
|
|
func (s *sqlDatabase) DeletePoolByID(_ context.Context, poolID string) error {
|
|
pool, err := s.getPoolByID(s.conn, poolID)
|
|
if err != nil {
|
|
return errors.Wrap(err, "fetching pool by ID")
|
|
}
|
|
|
|
if q := s.conn.Unscoped().Delete(&pool); q.Error != nil {
|
|
return errors.Wrap(q.Error, "removing pool")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *sqlDatabase) getEntityPool(tx *gorm.DB, entityType params.GithubEntityType, entityID, poolID string, preload ...string) (Pool, error) {
|
|
if entityID == "" {
|
|
return Pool{}, errors.Wrap(runnerErrors.ErrBadRequest, "missing entity id")
|
|
}
|
|
|
|
u, err := uuid.Parse(poolID)
|
|
if err != nil {
|
|
return Pool{}, errors.Wrap(runnerErrors.ErrBadRequest, "parsing id")
|
|
}
|
|
|
|
var fieldName string
|
|
var entityField string
|
|
switch entityType {
|
|
case params.GithubEntityTypeRepository:
|
|
fieldName = entityTypeRepoName
|
|
entityField = "Repository"
|
|
case params.GithubEntityTypeOrganization:
|
|
fieldName = entityTypeOrgName
|
|
entityField = "Organization"
|
|
case params.GithubEntityTypeEnterprise:
|
|
fieldName = entityTypeEnterpriseName
|
|
entityField = "Enterprise"
|
|
default:
|
|
return Pool{}, fmt.Errorf("invalid entityType: %v", entityType)
|
|
}
|
|
|
|
q := tx
|
|
q = q.Preload(entityField)
|
|
if len(preload) > 0 {
|
|
for _, item := range preload {
|
|
q = q.Preload(item)
|
|
}
|
|
}
|
|
|
|
var pool Pool
|
|
condition := fmt.Sprintf("id = ? and %s = ?", fieldName)
|
|
err = q.Model(&Pool{}).
|
|
Where(condition, u, entityID).
|
|
First(&pool).Error
|
|
if err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return Pool{}, errors.Wrap(runnerErrors.ErrNotFound, "finding pool")
|
|
}
|
|
return Pool{}, errors.Wrap(err, "fetching pool")
|
|
}
|
|
|
|
return pool, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) listEntityPools(tx *gorm.DB, entityType params.GithubEntityType, entityID string, preload ...string) ([]Pool, error) {
|
|
if _, err := uuid.Parse(entityID); err != nil {
|
|
return nil, errors.Wrap(runnerErrors.ErrBadRequest, "parsing id")
|
|
}
|
|
|
|
if err := s.hasGithubEntity(tx, entityType, entityID); err != nil {
|
|
return nil, errors.Wrap(err, "checking entity existence")
|
|
}
|
|
|
|
var preloadEntity string
|
|
var fieldName string
|
|
switch entityType {
|
|
case params.GithubEntityTypeRepository:
|
|
fieldName = entityTypeRepoName
|
|
preloadEntity = "Repository"
|
|
case params.GithubEntityTypeOrganization:
|
|
fieldName = entityTypeOrgName
|
|
preloadEntity = "Organization"
|
|
case params.GithubEntityTypeEnterprise:
|
|
fieldName = entityTypeEnterpriseName
|
|
preloadEntity = "Enterprise"
|
|
default:
|
|
return nil, fmt.Errorf("invalid entityType: %v", entityType)
|
|
}
|
|
|
|
q := tx
|
|
q = q.Preload(preloadEntity)
|
|
if len(preload) > 0 {
|
|
for _, item := range preload {
|
|
q = q.Preload(item)
|
|
}
|
|
}
|
|
|
|
var pools []Pool
|
|
condition := fmt.Sprintf("%s = ?", fieldName)
|
|
err := q.Model(&Pool{}).
|
|
Where(condition, entityID).
|
|
Omit("extra_specs").
|
|
Find(&pools).Error
|
|
if err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return []Pool{}, nil
|
|
}
|
|
return nil, errors.Wrap(err, "fetching pool")
|
|
}
|
|
|
|
return pools, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) findPoolByTags(id string, poolType params.GithubEntityType, tags []string) ([]params.Pool, error) {
|
|
if len(tags) == 0 {
|
|
return nil, runnerErrors.NewBadRequestError("missing tags")
|
|
}
|
|
u, err := uuid.Parse(id)
|
|
if err != nil {
|
|
return nil, errors.Wrap(runnerErrors.ErrBadRequest, "parsing id")
|
|
}
|
|
|
|
var fieldName string
|
|
switch poolType {
|
|
case params.GithubEntityTypeRepository:
|
|
fieldName = entityTypeRepoName
|
|
case params.GithubEntityTypeOrganization:
|
|
fieldName = entityTypeOrgName
|
|
case params.GithubEntityTypeEnterprise:
|
|
fieldName = entityTypeEnterpriseName
|
|
default:
|
|
return nil, fmt.Errorf("invalid poolType: %v", poolType)
|
|
}
|
|
|
|
var pools []Pool
|
|
where := fmt.Sprintf("tags.name in ? and %s = ? and enabled = true", fieldName)
|
|
q := s.conn.Joins("JOIN pool_tags on pool_tags.pool_id=pools.id").
|
|
Joins("JOIN tags on tags.id=pool_tags.tag_id").
|
|
Group("pools.id").
|
|
Preload("Tags").
|
|
Having("count(1) = ?", len(tags)).
|
|
Where(where, tags, u).
|
|
Order("priority desc").
|
|
Find(&pools)
|
|
|
|
if q.Error != nil {
|
|
if errors.Is(q.Error, gorm.ErrRecordNotFound) {
|
|
return nil, runnerErrors.ErrNotFound
|
|
}
|
|
return nil, errors.Wrap(q.Error, "fetching pool")
|
|
}
|
|
|
|
if len(pools) == 0 {
|
|
return nil, runnerErrors.ErrNotFound
|
|
}
|
|
|
|
ret := make([]params.Pool, len(pools))
|
|
for idx, val := range pools {
|
|
ret[idx], err = s.sqlToCommonPool(val)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "converting pool")
|
|
}
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) FindPoolsMatchingAllTags(_ context.Context, entityType params.GithubEntityType, entityID string, tags []string) ([]params.Pool, error) {
|
|
if len(tags) == 0 {
|
|
return nil, runnerErrors.NewBadRequestError("missing tags")
|
|
}
|
|
|
|
pools, err := s.findPoolByTags(entityID, entityType, tags)
|
|
if err != nil {
|
|
if errors.Is(err, runnerErrors.ErrNotFound) {
|
|
return []params.Pool{}, nil
|
|
}
|
|
return nil, errors.Wrap(err, "fetching pools")
|
|
}
|
|
|
|
return pools, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) CreateEntityPool(_ context.Context, entity params.GithubEntity, param params.CreatePoolParams) (params.Pool, error) {
|
|
if len(param.Tags) == 0 {
|
|
return params.Pool{}, runnerErrors.NewBadRequestError("no tags specified")
|
|
}
|
|
|
|
newPool := Pool{
|
|
ProviderName: param.ProviderName,
|
|
MaxRunners: param.MaxRunners,
|
|
MinIdleRunners: param.MinIdleRunners,
|
|
RunnerPrefix: param.GetRunnerPrefix(),
|
|
Image: param.Image,
|
|
Flavor: param.Flavor,
|
|
OSType: param.OSType,
|
|
OSArch: param.OSArch,
|
|
Enabled: param.Enabled,
|
|
RunnerBootstrapTimeout: param.RunnerBootstrapTimeout,
|
|
GitHubRunnerGroup: param.GitHubRunnerGroup,
|
|
Priority: param.Priority,
|
|
}
|
|
if len(param.ExtraSpecs) > 0 {
|
|
newPool.ExtraSpecs = datatypes.JSON(param.ExtraSpecs)
|
|
}
|
|
|
|
entityID, err := uuid.Parse(entity.ID)
|
|
if err != nil {
|
|
return params.Pool{}, errors.Wrap(runnerErrors.ErrBadRequest, "parsing id")
|
|
}
|
|
|
|
switch entity.EntityType {
|
|
case params.GithubEntityTypeRepository:
|
|
newPool.RepoID = &entityID
|
|
case params.GithubEntityTypeOrganization:
|
|
newPool.OrgID = &entityID
|
|
case params.GithubEntityTypeEnterprise:
|
|
newPool.EnterpriseID = &entityID
|
|
}
|
|
err = s.conn.Transaction(func(tx *gorm.DB) error {
|
|
if err := s.hasGithubEntity(tx, entity.EntityType, entity.ID); err != nil {
|
|
return errors.Wrap(err, "checking entity existence")
|
|
}
|
|
|
|
tags := []Tag{}
|
|
for _, val := range param.Tags {
|
|
t, err := s.getOrCreateTag(tx, val)
|
|
if err != nil {
|
|
return errors.Wrap(err, "creating tag")
|
|
}
|
|
tags = append(tags, t)
|
|
}
|
|
|
|
q := tx.Create(&newPool)
|
|
if q.Error != nil {
|
|
return errors.Wrap(q.Error, "creating pool")
|
|
}
|
|
|
|
for i := range tags {
|
|
if err := tx.Model(&newPool).Association("Tags").Append(&tags[i]); err != nil {
|
|
return errors.Wrap(err, "associating tags")
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return params.Pool{}, err
|
|
}
|
|
|
|
pool, err := s.getPoolByID(s.conn, newPool.ID.String(), "Tags", "Instances", "Enterprise", "Organization", "Repository")
|
|
if err != nil {
|
|
return params.Pool{}, errors.Wrap(err, "fetching pool")
|
|
}
|
|
|
|
return s.sqlToCommonPool(pool)
|
|
}
|
|
|
|
func (s *sqlDatabase) GetEntityPool(_ context.Context, entity params.GithubEntity, poolID string) (params.Pool, error) {
|
|
pool, err := s.getEntityPool(s.conn, entity.EntityType, entity.ID, poolID, "Tags", "Instances")
|
|
if err != nil {
|
|
return params.Pool{}, fmt.Errorf("fetching pool: %w", err)
|
|
}
|
|
return s.sqlToCommonPool(pool)
|
|
}
|
|
|
|
func (s *sqlDatabase) DeleteEntityPool(_ context.Context, entity params.GithubEntity, poolID string) error {
|
|
entityID, err := uuid.Parse(entity.ID)
|
|
if err != nil {
|
|
return errors.Wrap(runnerErrors.ErrBadRequest, "parsing id")
|
|
}
|
|
|
|
poolUUID, err := uuid.Parse(poolID)
|
|
if err != nil {
|
|
return errors.Wrap(runnerErrors.ErrBadRequest, "parsing pool id")
|
|
}
|
|
var fieldName string
|
|
switch entity.EntityType {
|
|
case params.GithubEntityTypeRepository:
|
|
fieldName = entityTypeRepoName
|
|
case params.GithubEntityTypeOrganization:
|
|
fieldName = entityTypeOrgName
|
|
case params.GithubEntityTypeEnterprise:
|
|
fieldName = entityTypeEnterpriseName
|
|
default:
|
|
return fmt.Errorf("invalid entityType: %v", entity.EntityType)
|
|
}
|
|
condition := fmt.Sprintf("id = ? and %s = ?", fieldName)
|
|
if err := s.conn.Unscoped().Where(condition, poolUUID, entityID).Delete(&Pool{}).Error; err != nil {
|
|
return errors.Wrap(err, "removing pool")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *sqlDatabase) UpdateEntityPool(_ context.Context, entity params.GithubEntity, poolID string, param params.UpdatePoolParams) (params.Pool, error) {
|
|
var updatedPool params.Pool
|
|
err := s.conn.Transaction(func(tx *gorm.DB) error {
|
|
pool, err := s.getEntityPool(tx, entity.EntityType, entity.ID, poolID, "Tags", "Instances")
|
|
if err != nil {
|
|
return errors.Wrap(err, "fetching pool")
|
|
}
|
|
|
|
updatedPool, err = s.updatePool(tx, pool, param)
|
|
if err != nil {
|
|
return errors.Wrap(err, "updating pool")
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return params.Pool{}, err
|
|
}
|
|
return updatedPool, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) ListEntityPools(_ context.Context, entity params.GithubEntity) ([]params.Pool, error) {
|
|
pools, err := s.listEntityPools(s.conn, entity.EntityType, entity.ID, "Tags")
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "fetching pools")
|
|
}
|
|
|
|
ret := make([]params.Pool, len(pools))
|
|
for idx, pool := range pools {
|
|
ret[idx], err = s.sqlToCommonPool(pool)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "fetching pool")
|
|
}
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) ListEntityInstances(_ context.Context, entity params.GithubEntity) ([]params.Instance, error) {
|
|
pools, err := s.listEntityPools(s.conn, entity.EntityType, entity.ID, "Instances", "Instances.Job")
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "fetching entity")
|
|
}
|
|
ret := []params.Instance{}
|
|
for _, pool := range pools {
|
|
for _, instance := range pool.Instances {
|
|
paramsInstance, err := s.sqlToParamsInstance(instance)
|
|
if err != nil {
|
|
return nil, errors.Wrap(err, "fetching instance")
|
|
}
|
|
ret = append(ret, paramsInstance)
|
|
}
|
|
}
|
|
return ret, nil
|
|
}
|