This change adds a new "generation" field to pools, scalesets and runners. The generation field is inherited by runners from scale sets or pools at the time of creation. The generation field on scalesets and pools is incremented when the pool or scale set is updated in a way that might influence how runners are created (flavor, image, specs, runner groups, etc). Using this new field, we can determine if existing runners have diverged from the settings of the pool/scale set that spawned them. In the CLI we now have a new set of commands available for both pools and scalesets that lists runners, with an optional --outdated flag and a new "rotate" flag that removes all idle runners. Optionally the --outdated flag can be passed to the rotate command to only remove outdated runners. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
477 lines
14 KiB
Go
477 lines
14 KiB
Go
// Copyright 2025 Cloudbase Solutions SRL
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
// not use this file except in compliance with the License. You may obtain
|
|
// a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
// License for the specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
package sql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/google/uuid"
|
|
"gorm.io/datatypes"
|
|
"gorm.io/gorm"
|
|
|
|
runnerErrors "github.com/cloudbase/garm-provider-common/errors"
|
|
"github.com/cloudbase/garm/database/common"
|
|
"github.com/cloudbase/garm/params"
|
|
)
|
|
|
|
func (s *sqlDatabase) ListAllScaleSets(_ context.Context) ([]params.ScaleSet, error) {
|
|
var scaleSets []ScaleSet
|
|
|
|
q := s.conn.Model(&ScaleSet{}).
|
|
Preload("Organization").
|
|
Preload("Organization.Endpoint").
|
|
Preload("Repository").
|
|
Preload("Repository.Endpoint").
|
|
Preload("Enterprise").
|
|
Preload("Enterprise.Endpoint").
|
|
Omit("extra_specs").
|
|
Omit("status_messages").
|
|
Find(&scaleSets)
|
|
if q.Error != nil {
|
|
return nil, fmt.Errorf("error fetching all scale sets: %w", q.Error)
|
|
}
|
|
|
|
ret := make([]params.ScaleSet, len(scaleSets))
|
|
var err error
|
|
for idx, val := range scaleSets {
|
|
ret[idx], err = s.sqlToCommonScaleSet(val)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error converting scale sets: %w", err)
|
|
}
|
|
}
|
|
return ret, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) CreateEntityScaleSet(ctx context.Context, entity params.ForgeEntity, param params.CreateScaleSetParams) (scaleSet params.ScaleSet, err error) {
|
|
if err := param.Validate(); err != nil {
|
|
return params.ScaleSet{}, fmt.Errorf("failed to validate create params: %w", err)
|
|
}
|
|
|
|
defer func() {
|
|
if err == nil {
|
|
s.sendNotify(common.ScaleSetEntityType, common.CreateOperation, scaleSet)
|
|
}
|
|
}()
|
|
|
|
newScaleSet := ScaleSet{
|
|
Name: param.Name,
|
|
ScaleSetID: param.ScaleSetID,
|
|
DisableUpdate: param.DisableUpdate,
|
|
ProviderName: param.ProviderName,
|
|
RunnerPrefix: param.GetRunnerPrefix(),
|
|
MaxRunners: param.MaxRunners,
|
|
MinIdleRunners: param.MinIdleRunners,
|
|
RunnerBootstrapTimeout: param.RunnerBootstrapTimeout,
|
|
Image: param.Image,
|
|
Flavor: param.Flavor,
|
|
OSType: param.OSType,
|
|
OSArch: param.OSArch,
|
|
Enabled: param.Enabled,
|
|
GitHubRunnerGroup: param.GitHubRunnerGroup,
|
|
State: params.ScaleSetPendingCreate,
|
|
TemplateID: param.TemplateID,
|
|
EnableShell: param.EnableShell,
|
|
}
|
|
|
|
if len(param.ExtraSpecs) > 0 {
|
|
newScaleSet.ExtraSpecs = datatypes.JSON(param.ExtraSpecs)
|
|
}
|
|
|
|
entityID, err := uuid.Parse(entity.ID)
|
|
if err != nil {
|
|
return params.ScaleSet{}, fmt.Errorf("error parsing id: %w", runnerErrors.ErrBadRequest)
|
|
}
|
|
|
|
switch entity.EntityType {
|
|
case params.ForgeEntityTypeRepository:
|
|
newScaleSet.RepoID = &entityID
|
|
case params.ForgeEntityTypeOrganization:
|
|
newScaleSet.OrgID = &entityID
|
|
case params.ForgeEntityTypeEnterprise:
|
|
newScaleSet.EnterpriseID = &entityID
|
|
}
|
|
err = s.conn.Transaction(func(tx *gorm.DB) error {
|
|
if err := s.hasGithubEntity(tx, entity.EntityType, entity.ID); err != nil {
|
|
return fmt.Errorf("error checking entity existence: %w", err)
|
|
}
|
|
|
|
q := tx.Create(&newScaleSet)
|
|
if q.Error != nil {
|
|
return fmt.Errorf("error creating scale set: %w", q.Error)
|
|
}
|
|
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return params.ScaleSet{}, err
|
|
}
|
|
|
|
dbScaleSet, err := s.GetScaleSetByID(ctx, newScaleSet.ID)
|
|
if err != nil {
|
|
return params.ScaleSet{}, fmt.Errorf("error fetching scale set: %w", err)
|
|
}
|
|
|
|
return dbScaleSet, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) listEntityScaleSets(tx *gorm.DB, entityType params.ForgeEntityType, entityID string, preload ...string) ([]ScaleSet, error) {
|
|
if _, err := uuid.Parse(entityID); err != nil {
|
|
return nil, fmt.Errorf("error parsing id: %w", runnerErrors.ErrBadRequest)
|
|
}
|
|
|
|
if err := s.hasGithubEntity(tx, entityType, entityID); err != nil {
|
|
return nil, fmt.Errorf("error checking entity existence: %w", err)
|
|
}
|
|
|
|
var preloadEntity string
|
|
var fieldName string
|
|
switch entityType {
|
|
case params.ForgeEntityTypeRepository:
|
|
fieldName = entityTypeRepoName
|
|
preloadEntity = repositoryFieldName
|
|
case params.ForgeEntityTypeOrganization:
|
|
fieldName = entityTypeOrgName
|
|
preloadEntity = organizationFieldName
|
|
case params.ForgeEntityTypeEnterprise:
|
|
fieldName = entityTypeEnterpriseName
|
|
preloadEntity = enterpriseFieldName
|
|
default:
|
|
return nil, fmt.Errorf("invalid entityType: %v", entityType)
|
|
}
|
|
|
|
q := tx
|
|
q = q.Preload(preloadEntity)
|
|
if len(preload) > 0 {
|
|
for _, item := range preload {
|
|
q = q.Preload(item)
|
|
}
|
|
}
|
|
|
|
var scaleSets []ScaleSet
|
|
condition := fmt.Sprintf("%s = ?", fieldName)
|
|
err := q.Model(&ScaleSet{}).
|
|
Where(condition, entityID).
|
|
Omit("extra_specs").
|
|
Omit("status_messages").
|
|
Find(&scaleSets).Error
|
|
if err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return []ScaleSet{}, nil
|
|
}
|
|
return nil, fmt.Errorf("error fetching scale sets: %w", err)
|
|
}
|
|
|
|
return scaleSets, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) ListEntityScaleSets(_ context.Context, entity params.ForgeEntity) ([]params.ScaleSet, error) {
|
|
scaleSets, err := s.listEntityScaleSets(s.conn, entity.EntityType, entity.ID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error fetching scale sets: %w", err)
|
|
}
|
|
|
|
ret := make([]params.ScaleSet, len(scaleSets))
|
|
for idx, set := range scaleSets {
|
|
ret[idx], err = s.sqlToCommonScaleSet(set)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error conbverting scale set: %w", err)
|
|
}
|
|
}
|
|
|
|
return ret, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) UpdateEntityScaleSet(ctx context.Context, entity params.ForgeEntity, scaleSetID uint, param params.UpdateScaleSetParams, callback func(old, newSet params.ScaleSet) error) (updatedScaleSet params.ScaleSet, err error) {
|
|
defer func() {
|
|
if err == nil {
|
|
s.sendNotify(common.ScaleSetEntityType, common.UpdateOperation, updatedScaleSet)
|
|
}
|
|
}()
|
|
err = s.conn.Transaction(func(tx *gorm.DB) error {
|
|
scaleSet, err := s.getEntityScaleSet(tx, entity.EntityType, entity.ID, scaleSetID, "Instances")
|
|
if err != nil {
|
|
return fmt.Errorf("error fetching scale set: %w", err)
|
|
}
|
|
|
|
old, err := s.sqlToCommonScaleSet(scaleSet)
|
|
if err != nil {
|
|
return fmt.Errorf("error converting scale set: %w", err)
|
|
}
|
|
|
|
updatedScaleSet, err = s.updateScaleSet(tx, scaleSet, param)
|
|
if err != nil {
|
|
return fmt.Errorf("error updating scale set: %w", err)
|
|
}
|
|
|
|
if callback != nil {
|
|
if err := callback(old, updatedScaleSet); err != nil {
|
|
return fmt.Errorf("error executing update callback: %w", err)
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return params.ScaleSet{}, err
|
|
}
|
|
|
|
updatedScaleSet, err = s.GetScaleSetByID(ctx, scaleSetID)
|
|
if err != nil {
|
|
return params.ScaleSet{}, err
|
|
}
|
|
return updatedScaleSet, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) getEntityScaleSet(tx *gorm.DB, entityType params.ForgeEntityType, entityID string, scaleSetID uint, preload ...string) (ScaleSet, error) {
|
|
if entityID == "" {
|
|
return ScaleSet{}, fmt.Errorf("error missing entity id: %w", runnerErrors.ErrBadRequest)
|
|
}
|
|
|
|
if scaleSetID == 0 {
|
|
return ScaleSet{}, fmt.Errorf("error missing scaleset id: %w", runnerErrors.ErrBadRequest)
|
|
}
|
|
|
|
var fieldName string
|
|
var entityField string
|
|
switch entityType {
|
|
case params.ForgeEntityTypeRepository:
|
|
fieldName = entityTypeRepoName
|
|
entityField = "Repository"
|
|
case params.ForgeEntityTypeOrganization:
|
|
fieldName = entityTypeOrgName
|
|
entityField = "Organization"
|
|
case params.ForgeEntityTypeEnterprise:
|
|
fieldName = entityTypeEnterpriseName
|
|
entityField = "Enterprise"
|
|
default:
|
|
return ScaleSet{}, fmt.Errorf("invalid entityType: %v", entityType)
|
|
}
|
|
|
|
q := tx
|
|
q = q.Preload(entityField)
|
|
if len(preload) > 0 {
|
|
for _, item := range preload {
|
|
q = q.Preload(item)
|
|
}
|
|
}
|
|
|
|
var scaleSet ScaleSet
|
|
condition := fmt.Sprintf("id = ? and %s = ?", fieldName)
|
|
err := q.Model(&ScaleSet{}).
|
|
Where(condition, scaleSetID, entityID).
|
|
First(&scaleSet).Error
|
|
if err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return ScaleSet{}, fmt.Errorf("error finding scale set: %w", runnerErrors.ErrNotFound)
|
|
}
|
|
return ScaleSet{}, fmt.Errorf("error fetching scale set: %w", err)
|
|
}
|
|
|
|
return scaleSet, nil
|
|
}
|
|
|
|
func (s *sqlDatabase) updateScaleSet(tx *gorm.DB, scaleSet ScaleSet, param params.UpdateScaleSetParams) (params.ScaleSet, error) {
|
|
incrementGeneration := false
|
|
if param.Enabled != nil && scaleSet.Enabled != *param.Enabled {
|
|
scaleSet.Enabled = *param.Enabled
|
|
}
|
|
|
|
if param.State != nil && *param.State != scaleSet.State {
|
|
scaleSet.State = *param.State
|
|
}
|
|
|
|
if param.ExtendedState != nil && *param.ExtendedState != scaleSet.ExtendedState {
|
|
scaleSet.ExtendedState = *param.ExtendedState
|
|
}
|
|
|
|
if param.ScaleSetID != 0 {
|
|
scaleSet.ScaleSetID = param.ScaleSetID
|
|
}
|
|
|
|
if param.TemplateID != nil {
|
|
scaleSet.TemplateID = param.TemplateID
|
|
}
|
|
|
|
if param.EnableShell != nil {
|
|
scaleSet.EnableShell = *param.EnableShell
|
|
incrementGeneration = true
|
|
}
|
|
|
|
if param.Name != "" {
|
|
scaleSet.Name = param.Name
|
|
}
|
|
|
|
if param.GitHubRunnerGroup != nil && *param.GitHubRunnerGroup != "" {
|
|
scaleSet.GitHubRunnerGroup = *param.GitHubRunnerGroup
|
|
incrementGeneration = true
|
|
}
|
|
|
|
if param.Flavor != "" {
|
|
scaleSet.Flavor = param.Flavor
|
|
incrementGeneration = true
|
|
}
|
|
|
|
if param.Image != "" {
|
|
scaleSet.Image = param.Image
|
|
incrementGeneration = true
|
|
}
|
|
|
|
if param.Prefix != "" {
|
|
scaleSet.RunnerPrefix = param.Prefix
|
|
}
|
|
|
|
if param.MaxRunners != nil {
|
|
scaleSet.MaxRunners = *param.MaxRunners
|
|
}
|
|
|
|
if param.MinIdleRunners != nil {
|
|
scaleSet.MinIdleRunners = *param.MinIdleRunners
|
|
}
|
|
|
|
if param.OSArch != "" {
|
|
scaleSet.OSArch = param.OSArch
|
|
incrementGeneration = true
|
|
}
|
|
|
|
if param.OSType != "" {
|
|
scaleSet.OSType = param.OSType
|
|
incrementGeneration = true
|
|
}
|
|
|
|
if param.ExtraSpecs != nil {
|
|
scaleSet.ExtraSpecs = datatypes.JSON(param.ExtraSpecs)
|
|
incrementGeneration = true
|
|
}
|
|
|
|
if param.RunnerBootstrapTimeout != nil && *param.RunnerBootstrapTimeout > 0 {
|
|
scaleSet.RunnerBootstrapTimeout = *param.RunnerBootstrapTimeout
|
|
}
|
|
|
|
if incrementGeneration {
|
|
scaleSet.Generation++
|
|
}
|
|
|
|
if q := tx.Save(&scaleSet); q.Error != nil {
|
|
return params.ScaleSet{}, fmt.Errorf("error saving database entry: %w", q.Error)
|
|
}
|
|
|
|
return s.sqlToCommonScaleSet(scaleSet)
|
|
}
|
|
|
|
func (s *sqlDatabase) GetScaleSetByID(_ context.Context, scaleSet uint) (params.ScaleSet, error) {
|
|
set, err := s.getScaleSetByID(
|
|
s.conn,
|
|
scaleSet,
|
|
"Instances",
|
|
"Enterprise",
|
|
"Enterprise.Endpoint",
|
|
"Organization",
|
|
"Organization.Endpoint",
|
|
"Repository",
|
|
"Repository.Endpoint",
|
|
"Template",
|
|
)
|
|
if err != nil {
|
|
return params.ScaleSet{}, fmt.Errorf("error fetching scale set by ID: %w", err)
|
|
}
|
|
return s.sqlToCommonScaleSet(set)
|
|
}
|
|
|
|
func (s *sqlDatabase) DeleteScaleSetByID(_ context.Context, scaleSetID uint) (err error) {
|
|
var scaleSet params.ScaleSet
|
|
defer func() {
|
|
if err == nil && scaleSet.ID != 0 {
|
|
s.sendNotify(common.ScaleSetEntityType, common.DeleteOperation, scaleSet)
|
|
}
|
|
}()
|
|
err = s.conn.Transaction(func(tx *gorm.DB) error {
|
|
dbSet, err := s.getScaleSetByID(tx, scaleSetID, "Instances", "Enterprise", "Organization", "Repository")
|
|
if err != nil {
|
|
return fmt.Errorf("error fetching scale set: %w", err)
|
|
}
|
|
|
|
if len(dbSet.Instances) > 0 {
|
|
return runnerErrors.NewBadRequestError("cannot delete scaleset with runners")
|
|
}
|
|
scaleSet, err = s.sqlToCommonScaleSet(dbSet)
|
|
if err != nil {
|
|
return fmt.Errorf("error converting scale set: %w", err)
|
|
}
|
|
|
|
if q := tx.Unscoped().Delete(&dbSet); q.Error != nil {
|
|
return fmt.Errorf("error deleting scale set: %w", q.Error)
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("error removing scale set: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *sqlDatabase) SetScaleSetLastMessageID(_ context.Context, scaleSetID uint, lastMessageID int64) (err error) {
|
|
var scaleSet params.ScaleSet
|
|
defer func() {
|
|
if err == nil && scaleSet.ID != 0 {
|
|
s.sendNotify(common.ScaleSetEntityType, common.UpdateOperation, scaleSet)
|
|
}
|
|
}()
|
|
if err := s.conn.Transaction(func(tx *gorm.DB) error {
|
|
dbSet, err := s.getScaleSetByID(tx, scaleSetID, "Instances", "Enterprise", "Organization", "Repository")
|
|
if err != nil {
|
|
return fmt.Errorf("error fetching scale set: %w", err)
|
|
}
|
|
dbSet.LastMessageID = lastMessageID
|
|
if err := tx.Save(&dbSet).Error; err != nil {
|
|
return fmt.Errorf("error saving database entry: %w", err)
|
|
}
|
|
scaleSet, err = s.sqlToCommonScaleSet(dbSet)
|
|
if err != nil {
|
|
return fmt.Errorf("error converting scale set: %w", err)
|
|
}
|
|
return nil
|
|
}); err != nil {
|
|
return fmt.Errorf("error setting last message ID: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s *sqlDatabase) SetScaleSetDesiredRunnerCount(_ context.Context, scaleSetID uint, desiredRunnerCount int) (err error) {
|
|
var scaleSet params.ScaleSet
|
|
defer func() {
|
|
if err == nil && scaleSet.ID != 0 {
|
|
s.sendNotify(common.ScaleSetEntityType, common.UpdateOperation, scaleSet)
|
|
}
|
|
}()
|
|
if err := s.conn.Transaction(func(tx *gorm.DB) error {
|
|
dbSet, err := s.getScaleSetByID(tx, scaleSetID, "Instances", "Enterprise", "Organization", "Repository")
|
|
if err != nil {
|
|
return fmt.Errorf("error fetching scale set: %w", err)
|
|
}
|
|
dbSet.DesiredRunnerCount = desiredRunnerCount
|
|
if err := tx.Save(&dbSet).Error; err != nil {
|
|
return fmt.Errorf("error saving database entry: %w", err)
|
|
}
|
|
scaleSet, err = s.sqlToCommonScaleSet(dbSet)
|
|
if err != nil {
|
|
return fmt.Errorf("error converting scale set: %w", err)
|
|
}
|
|
return nil
|
|
}); err != nil {
|
|
return fmt.Errorf("error setting desired runner count: %w", err)
|
|
}
|
|
return nil
|
|
}
|