From c5c74a8dfc33974ca022c4887e2a96ebdf3414ad Mon Sep 17 00:00:00 2001 From: Michael Kuhnt Date: Fri, 22 Nov 2024 10:32:13 +0100 Subject: [PATCH] add runner name in error message --- database/sql/jobs.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/database/sql/jobs.go b/database/sql/jobs.go index 887e041f..424bf8f4 100644 --- a/database/sql/jobs.go +++ b/database/sql/jobs.go @@ -3,6 +3,7 @@ package sql import ( "context" "encoding/json" + "fmt" "log/slog" "github.com/google/uuid" @@ -84,7 +85,8 @@ func (s *sqlDatabase) paramsJobToWorkflowJob(ctx context.Context, job params.Job if job.RunnerName != "" { instance, err := s.getInstanceByName(s.ctx, job.RunnerName) if err != nil { - slog.With(slog.Any("error", err)).ErrorContext(ctx, "failed to get instance by name") + // This usually is very normal as not all jobs run on our runners. + slog.DebugContext(ctx, fmt.Sprintf("failed to get instance by name: %s", job.RunnerName)) } else { workflofJob.InstanceID = &instance.ID } @@ -244,7 +246,8 @@ func (s *sqlDatabase) CreateOrUpdateJob(ctx context.Context, job params.Job) (pa if err == nil { workflowJob.InstanceID = &instance.ID } else { - slog.With(slog.Any("error", err)).ErrorContext(ctx, "failed to get instance by name") + // This usually is very normal as not all jobs run on our runners. + slog.DebugContext(ctx, fmt.Sprintf("failed to get instance by name: %s", job.RunnerName)) } }