From b6a02db44688e47e578e0657b9d5ed540bf53fcf Mon Sep 17 00:00:00 2001 From: Gabriel Adrian Samfira Date: Fri, 23 Jun 2023 21:14:22 +0000 Subject: [PATCH] Remove completed jobs and slight optimization * Removes completed jobs from the db * Skip ensure min idle runners for pools with min idle runners set to 0 Signed-off-by: Gabriel Adrian Samfira --- runner/pool/pool.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/runner/pool/pool.go b/runner/pool/pool.go index 18766241..4f439857 100644 --- a/runner/pool/pool.go +++ b/runner/pool/pool.go @@ -956,9 +956,10 @@ func (r *basePoolManager) addRunnerToPool(pool params.Pool) error { } func (r *basePoolManager) ensureIdleRunnersForOnePool(pool params.Pool) error { - if !pool.Enabled { + if !pool.Enabled || pool.MinIdleRunners == 0 { return nil } + existingInstances, err := r.store.ListPoolInstances(r.ctx, pool.ID) if err != nil { return fmt.Errorf("failed to ensure minimum idle workers for pool %s: %w", pool.ID, err) @@ -1514,5 +1515,9 @@ func (r *basePoolManager) consumeQueuedJobs() error { } } } + + if err := r.store.DeleteCompletedJobs(r.ctx); err != nil { + log.Printf("failed to delete completed jobs: %q", err) + } return nil }