From b4e7dead1ccd84c4d341aaacf093a48eb15f2949 Mon Sep 17 00:00:00 2001 From: Mario Constanti Date: Wed, 5 Jun 2024 13:48:53 +0200 Subject: [PATCH] fix: check if runner name is empty and return Signed-off-by: Mario Constanti --- runner/pool/pool.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/runner/pool/pool.go b/runner/pool/pool.go index 6a7b5632..1261ad21 100644 --- a/runner/pool/pool.go +++ b/runner/pool/pool.go @@ -209,6 +209,13 @@ func (r *basePoolManager) HandleWorkflowJob(job params.WorkflowJob) error { return errors.Wrap(err, "converting job to params") } + // If job was not assigned to a runner, we can ignore it. + if jobParams.RunnerName == "" { + slog.InfoContext( + r.ctx, "job never got assigned to a runner, ignoring") + return nil + } + // update instance workload state. if _, err := r.setInstanceRunnerStatus(jobParams.RunnerName, params.RunnerTerminated); err != nil { if errors.Is(err, runnerErrors.ErrNotFound) {