From baa7df65a41d95cd9165a0023f5b6feafb422b09 Mon Sep 17 00:00:00 2001 From: Gabriel Adrian Samfira Date: Fri, 25 Aug 2023 08:57:24 +0000 Subject: [PATCH] Fix garm pool manager startup If we fail to get the tools for one pool, garm fails to start due to pool manager startup timeout. Launch the initial tools update function as a goroutine and return from Start(). If it fails, it will retry, and we won't block garm from starting. Signed-off-by: Gabriel Adrian Samfira --- runner/pool/pool.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runner/pool/pool.go b/runner/pool/pool.go index 55b63692..d07ec924 100644 --- a/runner/pool/pool.go +++ b/runner/pool/pool.go @@ -1374,7 +1374,7 @@ func (r *basePoolManager) cleanupOrphanedRunners() error { } func (r *basePoolManager) Start() error { - r.updateTools() //nolint + go r.updateTools() //nolint go r.startLoopForFunction(r.runnerCleanup, common.PoolReapTimeoutInterval, "timeout_reaper", false) go r.startLoopForFunction(r.scaleDown, common.PoolScaleDownInterval, "scale_down", false)