DevFW-CICD/garm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Merge pull request #402 from gabriel-samfira/fix-parse-error

Browse source 
Fix potential nil pointer dereference
This commit is contained in:
Gabriel 2025-05-21 22:50:44 +03:00 • committed by GitHub
commit ac0caa2ed9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
util/github/client.go
View file

@ -240,8 +240,13 @@ func (g *githubClient) ListEntityRunnerApplicationDownloads(ctx context.Context)
}
func parseError(response *github.Response, err error) error {
slog.Debug("parsing error", "status_code", response.StatusCode, "response", response, "error", err)
switch response.StatusCode {
var statusCode int
if response != nil {
statusCode = response.StatusCode
}
slog.Debug("parsing error", "status_code", statusCode, "response", response, "error", err)
switch statusCode {
case http.StatusNotFound:
return runnerErrors.ErrNotFound
case http.StatusUnauthorized:
@ -249,7 +254,7 @@ func parseError(response *github.Response, err error) error {
case http.StatusUnprocessableEntity:
return runnerErrors.ErrBadRequest
default:
if response.StatusCode >= 100 && response.StatusCode < 300 {
if statusCode >= 100 && statusCode < 300 {
return nil
}
if err != nil {