Move URLs from default section of config to DB

This change moves the callback_url, metadata_url and webhooks_url from
the config to the database. The goal is to move as much as possible from
the config to the DB, in preparation for a potential refactor that will
allow GARM to scale out. This would allow multiple nodes to share a single
source of truth.

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>

database/sql/controller.go

@@ -15,6 +15,8 @@
 package sql
 
 import (
+	"net/url"
+
 	"github.com/google/uuid"
 	"github.com/pkg/errors"
 	"gorm.io/gorm"
@@ -23,6 +25,21 @@ import (
 	"github.com/cloudbase/garm/params"
 )
 
+func dbControllerToCommonController(dbInfo ControllerInfo) (params.ControllerInfo, error) {
+	url, err := url.JoinPath(dbInfo.WebhookBaseURL, dbInfo.ControllerID.String())
+	if err != nil {
+		return params.ControllerInfo{}, errors.Wrap(err, "joining webhook URL")
+	}
+
+	return params.ControllerInfo{
+		ControllerID:         dbInfo.ControllerID,
+		MetadataURL:          dbInfo.MetadataURL,
+		WebhookURL:           dbInfo.WebhookBaseURL,
+		ControllerWebhookURL: url,
+		CallbackURL:          dbInfo.CallbackURL,
+	}, nil
+}
+
 func (s *sqlDatabase) ControllerInfo() (params.ControllerInfo, error) {
 	var info ControllerInfo
 	q := s.conn.Model(&ControllerInfo{}).First(&info)
@@ -32,9 +49,13 @@ func (s *sqlDatabase) ControllerInfo() (params.ControllerInfo, error) {
 		}
 		return params.ControllerInfo{}, errors.Wrap(q.Error, "fetching controller info")
 	}
-	return params.ControllerInfo{
-		ControllerID: info.ControllerID,
-	}, nil
+
+	paramInfo, err := dbControllerToCommonController(info)
+	if err != nil {
+		return params.ControllerInfo{}, errors.Wrap(err, "converting controller info")
+	}
+
+	return paramInfo, nil
 }
 
 func (s *sqlDatabase) InitController() (params.ControllerInfo, error) {
@@ -60,3 +81,41 @@ func (s *sqlDatabase) InitController() (params.ControllerInfo, error) {
 		ControllerID: newInfo.ControllerID,
 	}, nil
 }
+
+func (s *sqlDatabase) UpdateController(info params.UpdateControllerParams) (params.ControllerInfo, error) {
+	var dbInfo ControllerInfo
+	q := s.conn.Model(&ControllerInfo{}).First(&dbInfo)
+	if q.Error != nil {
+		if errors.Is(q.Error, gorm.ErrRecordNotFound) {
+			return params.ControllerInfo{}, errors.Wrap(runnerErrors.ErrNotFound, "fetching controller info")
+		}
+		return params.ControllerInfo{}, errors.Wrap(q.Error, "fetching controller info")
+	}
+
+	if err := info.Validate(); err != nil {
+		return params.ControllerInfo{}, errors.Wrap(err, "validating controller info")
+	}
+
+	if info.MetadataURL != nil {
+		dbInfo.MetadataURL = *info.MetadataURL
+	}
+
+	if info.CallbackURL != nil {
+		dbInfo.CallbackURL = *info.CallbackURL
+	}
+
+	if info.WebhookURL != nil {
+		dbInfo.WebhookBaseURL = *info.WebhookURL
+	}
+
+	q = s.conn.Save(&dbInfo)
+	if q.Error != nil {
+		return params.ControllerInfo{}, errors.Wrap(q.Error, "saving controller info")
+	}
+
+	paramInfo, err := dbControllerToCommonController(dbInfo)
+	if err != nil {
+		return params.ControllerInfo{}, errors.Wrap(err, "converting controller info")
+	}
+	return paramInfo, nil
+}

database/sql/models.go

@@ -207,6 +207,10 @@ type ControllerInfo struct {
 	Base
 
 	ControllerID uuid.UUID
+
+	CallbackURL    string
+	MetadataURL    string
+	WebhookBaseURL string
 }
 
 type WorkflowJob struct {