DevFW-CICD/garm
16
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

refactor(params): ♻️ Simplify ForgeURL logic by removing redundant switch case
Some checks failed
CodeQL / Analyze (push) Failing after 1s
Details
Go Tests / Linters (push) Successful in 3m59s
Details
Go Tests / go-tests (push) Successful in 4m43s
Details

Browse source 
Streamlines the ForgeURL method by removing an unnecessary nested switch case
on ForgeType, consolidating the logic to rely solely on EntityType. This change
reduces complexity and improves code readability without altering functionality.
This commit is contained in:
Daniel Sy 2025-08-27 16:04:56 +02:00 • committed by Martin McCaffery
parent 90fe8c9a57
commit 8f1cd9f974
Signed by: martin.mccaffery
GPG key ID: 7C4D0F375BCEE533
1 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

19
params/params.go
View file

@ -1377,18 +1377,13 @@ func (g ForgeEntity) GetForgeType() (EndpointType, error) {
func (g ForgeEntity) ForgeURL() string {
baseURL := strings.TrimRight(g.Credentials.BaseURL, "/")
switch g.Credentials.ForgeType {
case GiteaEndpointType:
return g.Credentials.Endpoint.APIBaseURL
default:
switch g.EntityType {
case ForgeEntityTypeRepository:
return fmt.Sprintf("%s/%s/%s", baseURL, g.Owner, g.Name)
case ForgeEntityTypeOrganization:
return fmt.Sprintf("%s/%s", baseURL, g.Owner)
case ForgeEntityTypeEnterprise:
return fmt.Sprintf("%s/enterprises/%s", baseURL, g.Owner)
}
switch g.EntityType {
case ForgeEntityTypeRepository:
return fmt.Sprintf("%s/%s/%s", baseURL, g.Owner, g.Name)
case ForgeEntityTypeOrganization:
return fmt.Sprintf("%s/%s", baseURL, g.Owner)
case ForgeEntityTypeEnterprise:
return fmt.Sprintf("%s/enterprises/%s", baseURL, g.Owner)
}
return ""
}