DevFW-CICD/garm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Allow configuration of job backoff interval

Browse source 
GARM has a backoff interval when consuming queued jobs. This backoff
is intended to allow any potential idle runners to pick up a job before
GARM attempts to spin up a new one. This change allows users to set a
custom backoff interval or disable it altogether by setting it to 0.

Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This commit is contained in:
Gabriel Adrian Samfira 2024-07-01 10:27:31 +00:00
parent 8f0d44742e
commit 892a62bfe4
8 changed files with 90 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

10
cmd/garm-cli/cmd/controller.go
View file

@ -113,9 +113,13 @@ up the GARM controller URLs as:
params.WebhookURL = &webhookURL
}
if params.WebhookURL == nil && params.MetadataURL == nil && params.CallbackURL == nil {
if cmd.Flags().Changed("minimum-job-age-backoff") {
params.MinimumJobAgeBackoff = &minimumJobAgeBackoff
}
if params.WebhookURL == nil && params.MetadataURL == nil && params.CallbackURL == nil && params.MinimumJobAgeBackoff == nil {
cmd.Help()
return fmt.Errorf("at least one of metadata-url, callback-url or webhook-url must be provided")
return fmt.Errorf("at least one of minimum-job-age-backoff, metadata-url, callback-url or webhook-url must be provided")
}
updateUrlsReq := apiClientController.NewUpdateControllerParams()
@ -151,6 +155,7 @@ func renderControllerInfoTable(info params.ControllerInfo) string {
t.AppendRow(table.Row{"Callback URL", info.CallbackURL})
t.AppendRow(table.Row{"Webhook Base URL", info.WebhookURL})
t.AppendRow(table.Row{"Controller Webhook URL", info.ControllerWebhookURL})
t.AppendRow(table.Row{"Minimum Job Age Backoff", info.MinimumJobAgeBackoff})
return t.Render()
}
@ -163,6 +168,7 @@ func init() {
controllerUpdateCmd.Flags().StringVarP(&metadataURL, "metadata-url", "m", "", "The metadata URL for the controller (ie. https://garm.example.com/api/v1/metadata)")
controllerUpdateCmd.Flags().StringVarP(&callbackURL, "callback-url", "c", "", "The callback URL for the controller (ie. https://garm.example.com/api/v1/callbacks)")
controllerUpdateCmd.Flags().StringVarP(&webhookURL, "webhook-url", "w", "", "The webhook URL for the controller (ie. https://garm.example.com/webhooks)")
controllerUpdateCmd.Flags().UintVarP(&minimumJobAgeBackoff, "minimum-job-age-backoff", "b", 0, "The minimum job age backoff for the controller")
controllerCmd.AddCommand(
controllerShowCmd,

7
cmd/garm-cli/cmd/init.go
View file

@ -33,9 +33,10 @@ import (
)
var (
callbackURL string
metadataURL string
webhookURL string
callbackURL string
metadataURL string
webhookURL string
minimumJobAgeBackoff uint
)
// initCmd represents the init command