From 72ec1bf68f4c2f6b0f61111a6e5d33db71ccf3fd Mon Sep 17 00:00:00 2001 From: Gabriel Adrian Samfira Date: Fri, 30 Dec 2022 15:13:49 +0000 Subject: [PATCH] No need to explicitly call Stop() on runner loops Once the context is canceled, the loops will exit, so there is no need to explicitly Stop(). We just need to Wait() for the loops to exit. --- cmd/garm/main.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/garm/main.go b/cmd/garm/main.go index b6ee0884..00d6c114 100644 --- a/cmd/garm/main.go +++ b/cmd/garm/main.go @@ -172,11 +172,7 @@ func main() { if err := srv.Shutdown(shutdownCtx); err != nil { log.Printf("graceful api server shutdown failed: %+v", err) } - log.Printf("stopping runner loop") - if err := runner.Stop(); err != nil { - log.Printf("failed to shutdown workers: %+v", err) - os.Exit(1) - } + log.Printf("waiting for runner to stop") if err := runner.Wait(); err != nil { log.Printf("failed to shutdown workers: %+v", err)