diff --git a/runner/common_test.go b/runner/common_test.go new file mode 100644 index 00000000..b9b53545 --- /dev/null +++ b/runner/common_test.go @@ -0,0 +1,9 @@ +package runner + +const ( + // nolint: gosec + notExistingCredentialsName = "not-existent-creds-name" + // nolint: gosec + invalidCredentialsName = "invalid-creds-name" + notExistingProviderName = "not-existent-provider-name" +) diff --git a/runner/enterprises_test.go b/runner/enterprises_test.go index feabd8eb..5af95d96 100644 --- a/runner/enterprises_test.go +++ b/runner/enterprises_test.go @@ -184,7 +184,7 @@ func (s *EnterpriseTestSuite) TestCreateEnterpriseEmptyParams() { } func (s *EnterpriseTestSuite) TestCreateEnterpriseMissingCredentials() { - s.Fixtures.CreateEnterpriseParams.CredentialsName = "not-existent-creds-name" + s.Fixtures.CreateEnterpriseParams.CredentialsName = notExistingCredentialsName _, err := s.Runner.CreateEnterprise(s.Fixtures.AdminContext, s.Fixtures.CreateEnterpriseParams) @@ -309,7 +309,7 @@ func (s *EnterpriseTestSuite) TestUpdateEnterpriseErrUnauthorized() { } func (s *EnterpriseTestSuite) TestUpdateEnterpriseInvalidCreds() { - s.Fixtures.UpdateRepoParams.CredentialsName = "invalid-creds-name" + s.Fixtures.UpdateRepoParams.CredentialsName = invalidCredentialsName _, err := s.Runner.UpdateEnterprise(s.Fixtures.AdminContext, s.Fixtures.StoreEnterprises["test-enterprise-1"].ID, s.Fixtures.UpdateRepoParams) @@ -371,7 +371,7 @@ func (s *EnterpriseTestSuite) TestCreateEnterprisePoolErrNotFound() { } func (s *EnterpriseTestSuite) TestCreateEnterprisePoolFetchPoolParamsFailed() { - s.Fixtures.CreatePoolParams.ProviderName = "not-existent-provider-name" + s.Fixtures.CreatePoolParams.ProviderName = notExistingProviderName s.Fixtures.PoolMgrCtrlMock.On("GetEnterprisePoolManager", mock.AnythingOfType("params.Enterprise")).Return(s.Fixtures.PoolMgrMock, nil) diff --git a/runner/organizations_test.go b/runner/organizations_test.go index ebd2dda0..e3a43fad 100644 --- a/runner/organizations_test.go +++ b/runner/organizations_test.go @@ -184,7 +184,7 @@ func (s *OrgTestSuite) TestCreateOrganizationEmptyParams() { } func (s *OrgTestSuite) TestCreateOrganizationMissingCredentials() { - s.Fixtures.CreateOrgParams.CredentialsName = "not-existent-creds-name" + s.Fixtures.CreateOrgParams.CredentialsName = notExistingCredentialsName _, err := s.Runner.CreateOrganization(s.Fixtures.AdminContext, s.Fixtures.CreateOrgParams) @@ -309,7 +309,7 @@ func (s *OrgTestSuite) TestUpdateOrganizationErrUnauthorized() { } func (s *OrgTestSuite) TestUpdateOrganizationInvalidCreds() { - s.Fixtures.UpdateRepoParams.CredentialsName = "invalid-creds-name" + s.Fixtures.UpdateRepoParams.CredentialsName = invalidCredentialsName _, err := s.Runner.UpdateOrganization(s.Fixtures.AdminContext, s.Fixtures.StoreOrgs["test-org-1"].ID, s.Fixtures.UpdateRepoParams) @@ -371,7 +371,7 @@ func (s *OrgTestSuite) TestCreateOrgPoolErrNotFound() { } func (s *OrgTestSuite) TestCreateOrgPoolFetchPoolParamsFailed() { - s.Fixtures.CreatePoolParams.ProviderName = "not-existent-provider-name" + s.Fixtures.CreatePoolParams.ProviderName = notExistingProviderName s.Fixtures.PoolMgrCtrlMock.On("GetOrgPoolManager", mock.AnythingOfType("params.Organization")).Return(s.Fixtures.PoolMgrMock, nil) diff --git a/runner/repositories_test.go b/runner/repositories_test.go index f918132c..088301d3 100644 --- a/runner/repositories_test.go +++ b/runner/repositories_test.go @@ -185,7 +185,7 @@ func (s *RepoTestSuite) TestCreateRepositoryEmptyParams() { } func (s *RepoTestSuite) TestCreateRepositoryMissingCredentials() { - s.Fixtures.CreateRepoParams.CredentialsName = "not-existent-creds-name" + s.Fixtures.CreateRepoParams.CredentialsName = notExistingCredentialsName _, err := s.Runner.CreateRepository(s.Fixtures.AdminContext, s.Fixtures.CreateRepoParams) @@ -312,7 +312,7 @@ func (s *RepoTestSuite) TestUpdateRepositoryErrUnauthorized() { } func (s *RepoTestSuite) TestUpdateRepositoryInvalidCreds() { - s.Fixtures.UpdateRepoParams.CredentialsName = "invalid-creds-name" + s.Fixtures.UpdateRepoParams.CredentialsName = invalidCredentialsName _, err := s.Runner.UpdateRepository(s.Fixtures.AdminContext, s.Fixtures.StoreRepos["test-repo-1"].ID, s.Fixtures.UpdateRepoParams) @@ -374,7 +374,7 @@ func (s *RepoTestSuite) TestCreateRepoPoolErrNotFound() { } func (s *RepoTestSuite) TestCreateRepoPoolFetchPoolParamsFailed() { - s.Fixtures.CreatePoolParams.ProviderName = "not-existent-provider-name" + s.Fixtures.CreatePoolParams.ProviderName = notExistingProviderName s.Fixtures.PoolMgrCtrlMock.On("GetRepoPoolManager", mock.AnythingOfType("params.Repository")).Return(s.Fixtures.PoolMgrMock, nil)