From 4409beb18a137a0137a0d653542622991a989ee7 Mon Sep 17 00:00:00 2001 From: Mario Constanti Date: Thu, 22 Feb 2024 16:57:26 +0100 Subject: [PATCH] fix: G601: Implicit memory aliasing in for loop Signed-off-by: Mario Constanti --- database/sql/enterprise.go | 4 ++-- database/sql/organizations.go | 4 ++-- database/sql/repositories.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/database/sql/enterprise.go b/database/sql/enterprise.go index 94f751bf..5133b255 100644 --- a/database/sql/enterprise.go +++ b/database/sql/enterprise.go @@ -181,8 +181,8 @@ func (s *sqlDatabase) CreateEnterprisePool(ctx context.Context, enterpriseID str return params.Pool{}, errors.Wrap(q.Error, "adding pool") } - for _, tt := range tags { - if err := s.conn.Model(&newPool).Association("Tags").Append(&tt); err != nil { + for i := range tags { + if err := s.conn.Model(&newPool).Association("Tags").Append(&tags[i]); err != nil { return params.Pool{}, errors.Wrap(err, "saving tag") } } diff --git a/database/sql/organizations.go b/database/sql/organizations.go index 5d2f84a8..214757cf 100644 --- a/database/sql/organizations.go +++ b/database/sql/organizations.go @@ -198,8 +198,8 @@ func (s *sqlDatabase) CreateOrganizationPool(ctx context.Context, orgID string, return params.Pool{}, errors.Wrap(q.Error, "adding pool") } - for _, tt := range tags { - if err := s.conn.Model(&newPool).Association("Tags").Append(&tt); err != nil { + for i := range tags { + if err := s.conn.Model(&newPool).Association("Tags").Append(&tags[i]); err != nil { return params.Pool{}, errors.Wrap(err, "saving tag") } } diff --git a/database/sql/repositories.go b/database/sql/repositories.go index ca23c616..27adff32 100644 --- a/database/sql/repositories.go +++ b/database/sql/repositories.go @@ -198,8 +198,8 @@ func (s *sqlDatabase) CreateRepositoryPool(ctx context.Context, repoID string, p return params.Pool{}, errors.Wrap(q.Error, "adding pool") } - for _, tt := range tags { - if err := s.conn.Model(&newPool).Association("Tags").Append(&tt); err != nil { + for i := range tags { + if err := s.conn.Model(&newPool).Association("Tags").Append(&tags[i]); err != nil { return params.Pool{}, errors.Wrap(err, "saving tag") } }