DevFW-CICD/garm
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Fixed error wrap

Browse source 
The error is not wrapped correctly, because instead of using `q.Error`,
it uses `err`, which is defined elsewhere.

Also, the `UpdateRepository` and `CreateRepositoryPool` functions will
never fail on update/create repo, because it returns a nil error, instead
of wrap error.

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
This commit is contained in:
Mihaela Balutoiu 2022-10-17 17:46:56 +03:00
parent 996102fd98
commit 36a51f83ab
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
database/sql/repositories.go
View file

@ -125,7 +125,7 @@ func (s *sqlDatabase) UpdateRepository(ctx context.Context, repoID string, param
q := s.conn.Save(&repo)
if q.Error != nil {
return params.Repository{}, errors.Wrap(err, "saving repo")
return params.Repository{}, errors.Wrap(q.Error, "saving repo")
}
newParams := s.sqlToCommonRepository(repo)
@ -196,7 +196,7 @@ func (s *sqlDatabase) CreateRepositoryPool(ctx context.Context, repoId string, p
q := s.conn.Create(&newPool)
if q.Error != nil {
return params.Pool{}, errors.Wrap(err, "adding pool")
return params.Pool{}, errors.Wrap(q.Error, "adding pool")
}
for _, tt := range tags {