From 22fde8d30ed5dc98610ca5548a9f800d0bc88e4f Mon Sep 17 00:00:00 2001 From: Gabriel Adrian Samfira Date: Mon, 29 Sep 2025 09:25:54 +0000 Subject: [PATCH] Properly return error when checking for fallback The code that attempts to fetch tools from upstream, must return the error if the current setting is the upstream repo. Signed-off-by: Gabriel Adrian Samfira --- workers/cache/gitea_tools.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/workers/cache/gitea_tools.go b/workers/cache/gitea_tools.go index 58507370..2eda4a2b 100644 --- a/workers/cache/gitea_tools.go +++ b/workers/cache/gitea_tools.go @@ -185,14 +185,15 @@ func getTools(ctx context.Context, metadataURL string, useInternal bool) ([]comm slog.ErrorContext(ctx, "failed to get tools from metadata URL", "error", err) if metadataURL != appdefaults.GiteaRunnerReleasesURL { slog.InfoContext(ctx, "attempting to get tools from default upstream", "tools_url", appdefaults.GiteaRunnerReleasesURL) - latest, err = getReleasesFromURL(ctx, metadataURL) - if err != nil { - return nil, fmt.Errorf("failed to get upstream tools: %w", err) - } + latest, err = getReleasesFromURL(ctx, appdefaults.GiteaRunnerReleasesURL) } } } + if err != nil { + return nil, fmt.Errorf("failed to get tools: %w", err) + } + ret := []commonParams.RunnerApplicationDownload{} for _, asset := range latest.Assets {