From d4b603f4c8da99af32dd0b01ab3d9b06ad096a16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan-Otto=20Kr=C3=B6pke?= Date: Mon, 27 Sep 2021 14:06:24 +0200 Subject: [PATCH] feat(argocd-applicationset): Add extraArgs (#946) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * feat(argocd-applicationset): Add extraArgs Signed-off-by: Jan-Otto Kröpke * Align with existing code style Signed-off-by: Marco Kilchhofer * Fix linting error and update README Signed-off-by: Marco Kilchhofer Co-authored-by: Marco Kilchhofer --- charts/argocd-applicationset/Chart.yaml | 4 ++-- charts/argocd-applicationset/README.md | 1 + charts/argocd-applicationset/templates/deployment.yaml | 3 +++ charts/argocd-applicationset/values.yaml | 4 ++++ 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/charts/argocd-applicationset/Chart.yaml b/charts/argocd-applicationset/Chart.yaml index ba9b62cd..5b02af5c 100644 --- a/charts/argocd-applicationset/Chart.yaml +++ b/charts/argocd-applicationset/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: argocd-applicationset description: A Helm chart for installing ArgoCD ApplicationSet type: application -version: 1.4.0 +version: 1.5.0 appVersion: "v0.2.0" home: https://github.com/argoproj/argo-helm icon: https://argocd-applicationset.readthedocs.io/en/stable/assets/logo.png @@ -14,4 +14,4 @@ maintainers: - name: maruina annotations: artifacthub.io/changes: | - - "[Added]: Configuration for Pod labels" + - "[Added]: Add extraArgs to define additional CLI parameters" diff --git a/charts/argocd-applicationset/README.md b/charts/argocd-applicationset/README.md index 1683c33b..506880a6 100644 --- a/charts/argocd-applicationset/README.md +++ b/charts/argocd-applicationset/README.md @@ -65,6 +65,7 @@ kubectl apply -k https://github.com/argoproj-labs/applicationset.git/manifests/c | args.namespace | string | `"argocd"` | The default Argo CD repo namespace | | args.policy | string | `"sync"` | How application is synced between the generator and the cluster | | args.probeBindAddr | string | `":8081"` | The default health check port | +| extraArgs | list | `[]` | List of extra cli args to add | | extraVolumeMounts | list | `[]` | List of extra mounts to add (normally used with extraVolumes) | | extraVolumes | list | `[]` | List of extra volumes to add | | fullnameOverride | string | `""` | Override the default fully qualified app name | diff --git a/charts/argocd-applicationset/templates/deployment.yaml b/charts/argocd-applicationset/templates/deployment.yaml index a577854b..c0527562 100644 --- a/charts/argocd-applicationset/templates/deployment.yaml +++ b/charts/argocd-applicationset/templates/deployment.yaml @@ -44,6 +44,9 @@ spec: - --policy={{ .Values.args.policy }} - --debug={{ .Values.args.debug }} - --dry-run={{ .Values.args.dryRun }} + {{- with .Values.extraArgs }} + {{- toYaml . | nindent 12 }} + {{- end }} image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" imagePullPolicy: {{ .Values.image.pullPolicy }} ports: diff --git a/charts/argocd-applicationset/values.yaml b/charts/argocd-applicationset/values.yaml index 5c9f8225..fd5a50d5 100644 --- a/charts/argocd-applicationset/values.yaml +++ b/charts/argocd-applicationset/values.yaml @@ -113,3 +113,7 @@ extraVolumeMounts: [] extraVolumes: [] # - name: foobar # emptyDir: {} + +# -- List of extra cli args to add +extraArgs: [] + # - --loglevel=warn