feat(argo-workflows): Multiple workflow namespaces (#824)

* allow workflow to be run in multiple namespaces, bump chart version

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* update helm install instructions

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* fix indents

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* add newlines

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* bump chart version

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* default to "argo" namespace for workflow service account

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* simplify setting service account, fix syntactical error in defaulting to "argo" namespace

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* Bump only the chart version, revert bumping the controller version: 3.0.8 does not exist yet as a workflow-controller image version

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* don't set a namespace if there isn't one provided

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* bump version

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* re-use controller.workflowNamespaces instead of introducing workflow.namespaces, add additional inline comments on rbac.create effect

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* compress namespaces from controller.workflowNamespaces and workflow.namespace into single loop iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* dro now-redundant branch for controller.workflowNamespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* use template helper "argo-workflows.fullname" instead of release name in order to be able to override the service account name

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* add missing "template" keyword

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* drop redundant $namespace assignment that was already moved inside the "range" function

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* replace "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* drop redundant $namespace assignment that was already moved inside the "range" function

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* inline "define" templates with simple values now that controller.workflowNamespaces and workflow.namespace are unified into a single "range" iteration

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* add missing "$" to denote target for templating the workflows fullname helper

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* restore `with` blocks for service account name and service account annotations

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* drop validations: considering cases of `workflowNamespaces`, `namespace` and `singleNamespace`

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* include case for single namespaces with default ("") namespace, otherwise (ternary) combine the workflow namespace and workflowNamespaces from the controller settings into a list to iterate over

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* wrap namespace configuration in `with` block to prevent setting it to ""

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* fix append vs. concat bug: append workflowNamespace to (possibly 0-lenght) list of controller.workflowNamespaces

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>

* fix namespace range with additional check for either single namespace being false, or append to the workflow namespaces: the first non-null (coalesce) from the workflow namespace or the namespace Argo is being deployed to.

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* add changelog entries

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

* unwrap (inline) with-block for service account name

Signed-off-by: reinvantveer <reinvantveer@gmail.com>

Co-authored-by: Vlad Losev <vladlosev@users.noreply.github.com>

CONTRIBUTING.md

@@ -55,7 +55,7 @@ annotations:
 Minimally:
 
 ```
-helm install charts/argo -n argo
+helm install charts/argo-workflows -n argo
 argo version
 ```